Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 6721029: Fix locale.getlocale() exception. (Closed)

Created:
9 years, 9 months ago by M-A Ruel
Modified:
9 years, 7 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, M-A Ruel
Visibility:
Public.

Description

Fix locale.getlocale() exception. Reapply r79006 with fixes for ubuntu 10.4. The only change is in fix_default_encoding() to trap an exception locale.getlocale() may throw. R=dpranke@chromium.org BUG=none TEST=unit test Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=79144

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+442 lines, -14 lines) Patch
M PRESUBMIT.py View 1 chunk +1 line, -0 lines 0 comments Download
A fix_encoding.py View 1 chunk +356 lines, -0 lines 0 comments Download
M gcl.py View 2 chunks +2 lines, -0 lines 0 comments Download
M gclient.py View 2 chunks +2 lines, -0 lines 0 comments Download
M presubmit_support.py View 3 chunks +13 lines, -11 lines 0 comments Download
A tests/fix_encoding_test.py View 1 chunk +60 lines, -0 lines 0 comments Download
M tests/gcl_unittest.py View 1 chunk +2 lines, -1 line 0 comments Download
M tests/presubmit_unittest.py View 1 chunk +2 lines, -1 line 0 comments Download
M tests/trychange_unittest.py View 1 chunk +2 lines, -1 line 0 comments Download
M trychange.py View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
M-A Ruel
9 years, 9 months ago (2011-03-23 14:38:37 UTC) #1
Dirk Pranke
9 years, 9 months ago (2011-03-23 16:58:52 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698