Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2542)

Unified Diff: chrome/browser/sync/sessions/sessions_sync_manager.cc

Issue 672083002: Refactoring of SessionService to get componentized. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixing windows compile problem Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/sessions/sessions_sync_manager.cc
diff --git a/chrome/browser/sync/sessions/sessions_sync_manager.cc b/chrome/browser/sync/sessions/sessions_sync_manager.cc
index 0a92ddd3417656985e6a1d3c4a1f07b105288388..05bc926903316b5d7c39ed3b85ada16d4375c583 100644
--- a/chrome/browser/sync/sessions/sessions_sync_manager.cc
+++ b/chrome/browser/sync/sessions/sessions_sync_manager.cc
@@ -740,11 +740,13 @@ void SessionsSyncManager::BuildSyncedSessionFromSpecifics(
if (specifics.has_selected_tab_index())
session_window->selected_tab_index = specifics.selected_tab_index();
if (specifics.has_browser_type()) {
+ // TODO(skuhne): Sync data writes |BrowserType| not
+ // |SessionWindow::WindowType|. This should get changed.
if (specifics.browser_type() ==
sync_pb::SessionWindow_BrowserType_TYPE_TABBED) {
- session_window->type = 1;
+ session_window->type = SessionWindow::TYPE_TABBED;
} else {
- session_window->type = 2;
+ session_window->type = SessionWindow::TYPE_POPUP;
}
}
session_window->timestamp = mtime;
« no previous file with comments | « chrome/browser/sync/glue/session_sync_test_helper.cc ('k') | chrome/browser/sync/sessions/sessions_sync_manager_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698