Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1988)

Unified Diff: chrome/browser/sessions/session_types.h

Issue 672083002: Refactoring of SessionService to get componentized. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixing windows compile problem Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/sessions/session_service_utils.cc ('k') | chrome/browser/sessions/session_types.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sessions/session_types.h
diff --git a/chrome/browser/sessions/session_types.h b/chrome/browser/sessions/session_types.h
index 35b4d29bae78060651e76b8044c5596f7692b997..3ab53ff70fbb14c1f21a6b0297a841fac6aefcdd 100644
--- a/chrome/browser/sessions/session_types.h
+++ b/chrome/browser/sessions/session_types.h
@@ -109,6 +109,13 @@ struct SessionWindow {
SessionWindow();
~SessionWindow();
+ // Possible window types which can be stored here. Note that these values will
+ // be written out to disc via session commands.
+ enum WindowType {
+ TYPE_TABBED = 0,
+ TYPE_POPUP = 1
+ };
+
// Convert this object into its sync protocol buffer equivalent. Note that
// not all fields are synced here, because they don't all make sense or
// translate when restoring a SessionWindow on another device.
@@ -129,10 +136,9 @@ struct SessionWindow {
// tabs.
int selected_tab_index;
- // Type of the browser. Currently we only store browsers of type
- // TYPE_TABBED and TYPE_POPUP.
- // This would be Browser::Type, but that would cause a circular dependency.
- int type;
+ // Type of the window. Note: This type is used to determine if the window gets
+ // saved or not.
+ WindowType type;
// If true, the window is constrained.
//
« no previous file with comments | « chrome/browser/sessions/session_service_utils.cc ('k') | chrome/browser/sessions/session_types.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698