Refactoring of SessionService to get componentized.

chrome/browser/sessions/session_types.h

Index: chrome/browser/sessions/session_types.h
diff --git a/chrome/browser/sessions/session_types.h b/chrome/browser/sessions/session_types.h
index 35b4d29bae78060651e76b8044c5596f7692b997..e6a4b2405a761635377ac6b99c0b8dc7bb37ff92 100644
--- a/chrome/browser/sessions/session_types.h
+++ b/chrome/browser/sessions/session_types.h
@@ -109,6 +109,12 @@ struct SessionWindow {
   SessionWindow();
   ~SessionWindow();
 
+  // Possible window types which can be stored here.

[sky, 2014/10/29 20:49:15]

Document that these values are written to disk.

[Mr4D (OOO till 08-26), 2014/10/29 22:22:18]

Done. 

Note: I was under the assumption that that would not need to be commented since
this class has nothing (direct) with the session commands to do.

+  enum WindowType {
+    TYPE_TABBED = 0,
+    TYPE_POPUP = 1
+  };
+
   // Convert this object into its sync protocol buffer equivalent. Note that
   // not all fields are synced here, because they don't all make sense or
   // translate when restoring a SessionWindow on another device.
@@ -129,10 +135,9 @@ struct SessionWindow {
   // tabs.
   int selected_tab_index;
 
-  // Type of the browser. Currently we only store browsers of type
-  // TYPE_TABBED and TYPE_POPUP.
-  // This would be Browser::Type, but that would cause a circular dependency.
-  int type;
+  // Type of the window. Note: This type is used to determine if the window gets
+  // saved or not.
+  WindowType type;
 
   // If true, the window is constrained.
   //