chrome/browser/extensions/api/sessions/sessions_api.cc - Issue 672083002: Refactoring of SessionService to get componentized.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/sessions/sessions_api.cc

Issue 672083002: Refactoring of SessionService to get componentized. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Switched back to #2 and addressed points Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/sessions/sessions_api.cc

diff --git a/chrome/browser/extensions/api/sessions/sessions_api.cc b/chrome/browser/extensions/api/sessions/sessions_api.cc

index 0b7a1a71601b21940be8b9b68dfaa4c01282102f..cc4830816433b7a9b37cd47fd22128fee5be6cf8 100644

--- a/chrome/browser/extensions/api/sessions/sessions_api.cc

+++ b/chrome/browser/extensions/api/sessions/sessions_api.cc

@@ -289,10 +289,10 @@ scoped_ptr<windows::Window> SessionsGetDevicesFunction::CreateWindowModel(

windows::Window::Type type = windows::Window::TYPE_NONE;

switch (window.type) {

- case Browser::TYPE_TABBED:

+ case SessionWindow::TYPE_TABBED:

type = windows::Window::TYPE_NORMAL;

break;

- case Browser::TYPE_POPUP:

+ case SessionWindow::TYPE_POPUP:

type = windows::Window::TYPE_POPUP;

break;

}