Remove "static" files from the input list to fix the chromium shared build.

Remove "static" files from the input list to fix the chromium shared build.

[Craig Schlenter, 2009-04-16 17:11:09]

As part of getting the linux shared build up and running, one of the issues is
that the bison and gperf files leave either a .h file or the original gperf file
in the sources list. This makes scons unhappy as it sees these files as static
while the target it is building is shared and so it throws an error.

The change here tweaks the scons file to strip the header file and gperf file. I
think the change is ugly but my python/scons/gyp "skills" are _extremely_
limited and I couldn't think of another way to do this.

A related change to this is http://codereview.chromium.org/67212 btw.

Thank you!

[Craig Schlenter, 2009-04-17 05:59:10]

> The change here tweaks the scons file to strip the header file
> and gperf file. I think the change is ugly but my python/scons/gyp
> "skills" are _extremely_ limited and I couldn't think of another
> way to do this.

I been thinking that maybe a less hackish way to do this would be to have an
additional option that can be turned on similar to 
process_outputs_as_sources e.g. "remove_static_input_files" or
perhaps allow specifying some sort of regexp to control which files
are removed from the sources list? I'll have to go read a python
tutorial or something before I tackle that though ...

[Craig Schlenter, 2009-04-17 06:01:07]

> I been thinking that maybe a less hackish way

s/I/I've

[Craig Schlenter, 2009-04-17 19:03:13]

Now using correct address for Mark ...

[Mark Mentovai, 2009-04-17 19:06:08]

This looks right to me but sgk is definitely the expert, so I'll defer to him.

[sgk, 2009-04-17 22:17:49]

I think this is in the wrong place.

The issue is that we're defining a generic action here, and whether or not you
want to strip files (.h, .gperf) from the output list depends on what you're
going to build with that list.  In the case of a building a library, yes, we
want to strip those, but if we were using this list as input to building a
.tar.gz file, we'd want to keep them.

There's alseady code in site_scons/site_tools/chromium_builders.py that's
supposed to do this stripping when Chrome{Static,Shared}Library() is called.  It
doesn't list .gperf, but it does list .h, so I think we have a bug that's
preventing it from doing the job.  I'll download and apply your other patch and
track down that bug.

[Craig Schlenter, 2009-04-18 15:32:02]

On 2009/04/17 22:17:49, sgk wrote:
> I think this is in the wrong place.
[snip]
> There's alseady code in site_scons/site_tools/chromium_builders.py
> that's supposed to do this stripping when
> Chrome{Static,Shared}Library() is called.  It doesn't list .gperf,
> but it does list .h, so I think we have a bug that's preventing
> it from doing the job.  I'll download and apply your other patch
> and track down that bug.

Super, thank you. Here's a trace of the problem btw. in case it helps:

[craig@csinspiron build(sharedbuild)]$ hammer app -j 1 --verbose
--debug=stacktrace
scons: Reading SConscript files ...
scons: done reading SConscript files.
scons: Building targets ...
cd /home/craig/chromium.git/src/base && ../chrome/tools/build/linux/version.sh
file_version_info_linux.h.version
/home/craig/chromium.git/src/sconsbuild/Debug/obj/global_intermediate/base/file_version_info_linux.h
scons: *** [/home/craig/chromium.git/src/sconsbuild/Debug/lib/libwebcore.so]
Source file:
/home/craig/chromium.git/src/sconsbuild/Debug/obj/webkit/webcore/intermediate/CSSGrammar.h
is static and is not compatible with shared target:
/home/craig/chromium.git/src/sconsbuild/Debug/lib/libwebcore.so
scons: internal stack trace:
  File
"/home/craig/chromium.git/src/third_party/scons/scons-local/SCons/Job.py", line
199, in start
    task.execute()
  File
"/home/craig/chromium.git/src/third_party/scons/scons-local/SCons/Script/Main.py",
line 182, in execute
    SCons.Taskmaster.OutOfDateTask.execute(self)
  File
"/home/craig/chromium.git/src/third_party/scons/scons-local/SCons/Taskmaster.py",
line 230, in execute
    self.targets[0].build()
  File
"/home/craig/chromium.git/src/third_party/scons/scons-local/SCons/Node/__init__.py",
line 370, in build
    apply(self.get_executor(), (self,), kw)
  File
"/home/craig/chromium.git/src/third_party/scons/scons-local/SCons/Executor.py",
line 363, in __call__
    return self.do_execute(target, kw)
  File
"/home/craig/chromium.git/src/third_party/scons/scons-local/SCons/Executor.py",
line 345, in do_execute
    status = apply(act, args, kw)
  File
"/home/craig/chromium.git/src/third_party/scons/scons-local/SCons/Action.py",
line 1124, in __call__
    show, execute, chdir, executor)
  File
"/home/craig/chromium.git/src/third_party/scons/scons-local/SCons/Action.py",
line 561, in __call__
    stat = self.execute(target, source, env, executor=executor)
  File
"/home/craig/chromium.git/src/third_party/scons/scons-local/SCons/Action.py",
line 1060, in execute
    raise result
scons: building terminated because of errors.

The actual error message seems to come from SharedFlagChecker in
third_party/scons/scons-local/SCons/Defaults.py

Thank you

[sgk, 2009-04-21 00:03:49]

Fixed in site_scons/site_tools/chromium_builder.py by r14064.

[Craig Schlenter, 2009-04-21 03:25:33]

On 2009/04/21 00:03:49, sgk wrote:
> Fixed in site_scons/site_tools/chromium_builder.py by r14064.

Excellent! Thank you. Will close this issue.