Browser Crash when opening urls with NEW_BACKGROUND_TAB disposition...

Browser Crash when opening urls with NEW_BACKGROUND_TAB disposition

When that disposition is used and no "normal" window is opened, it crashes. "normal" means non POPUP, non APPLICATION window type. This happens because background disposition doens't focus or activate the window unless selected. A crash happens because GetSelectedTabContents() is null since nothing initially there.

This fix might have stopped it crash, but would be best to see if its a "good" approach.

I fixed some lints such as, header file already exists, extra white space, etc)
BUG=10591
( http://crbug.com/10591 )

[Elliot Glaysher, 2009-04-16 20:22:31]

I confirm that this works. I'd like Ben to address whether this is a good
design, though.

[Peter Kasting, 2009-04-16 21:16:40]

http://codereview.chromium.org/67205/diff/1003/1004
File chrome/browser/browser.cc (right):

http://codereview.chromium.org/67205/diff/1003/1004#newcode1670
Line 1670: // If this is an application we can only have one tab so a new tab
always
Maybe instead of your fix below, we should expand this to basically be "if type_
!= normal" so it happens for popups too.  Note how this will auto-change the
disposition.

http://codereview.chromium.org/67205/diff/1003/1004#newcode2336
Line 2336: && GetSelectedTabContents())
Nit: "&&" on previous line

Shouldn't this be unnecessary now that there's always a selected tab contents?

[Mohamed Mansour (USE mhm), 2009-04-17 04:22:15]

Peter, thanks for your comments, your totally correct. I have worked backwards
doing this patch and it can all be simplified.

New patch uploaded, please review and let me know if this approach is
acceptable. 

Thanks!

[Peter Kasting, 2009-04-17 16:52:03]

LGTM

[Hironori Bono, 2009-04-22 09:49:03]

pkasting,

Mohamed asked me when we commit this change today.
Is it possible for me to commit it on your behalf?

Regards,

Hironori Bono

On 2009/04/17 16:52:03, pkasting wrote:
> LGTM

[Hironori Bono, 2009-04-23 06:22:34]

It was submitted as r14288 on behalf of pkasting.
Thank you so much for your work for Chromium.