Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(664)

Unified Diff: shell/subcmds/build_cmd.py

Issue 6720024: Plumb in subcommand options (Closed) Base URL: ssh://gitrw.chromium.org:9222/chromite.git@master
Patch Set: Moved docstring into docstring :-) Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « shell/main_unittest.py ('k') | shell/subcmds/clean_cmd.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: shell/subcmds/build_cmd.py
diff --git a/shell/subcmds/build_cmd.py b/shell/subcmds/build_cmd.py
index 9122cc4ce7b3254ce774e2d056fb45fb0813d1da..d9750e2b147e9c17bce9a6c5bb0f018dfcedba79 100644
--- a/shell/subcmds/build_cmd.py
+++ b/shell/subcmds/build_cmd.py
@@ -64,7 +64,7 @@ def _DoSetupBoard(cros_env, build_config, clean_first):
return
# Put together command.
- cmd_list = [
+ arg_list = [
'--board="%s"' % build_config.get('DEFAULT', 'target'),
build_config.get('BUILD', 'setup_board_flags'),
]
@@ -156,11 +156,9 @@ class BuildCmd(subcmd.ChromiteCmd):
usage_str = ('usage: %%prog [chromite_options] %s [options] [target]' %
raw_argv[0])
parser = optparse.OptionParser(usage=usage_str)
- # This option won't work until a later CL plumbs in optparse
- #parser.add_option('--clean', default=False, action='store_true',
- #help='Clean before building.')
+ parser.add_option('--clean', default=False, action='store_true',
+ help='Clean before building.')
(options, argv) = parser.parse_args(raw_argv[1:])
- options.clean = False
# Load the build config if needed...
if not loaded_config:
« no previous file with comments | « shell/main_unittest.py ('k') | shell/subcmds/clean_cmd.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698