Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Side by Side Diff: content/browser/host_zoom_map_unittest.cc

Issue 6720013: Get rid of PrefService::GetMutableDictionary/GetMutableList (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « content/browser/host_zoom_map.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/memory/ref_counted.h" 5 #include "base/memory/ref_counted.h"
6 #include "base/message_loop.h" 6 #include "base/message_loop.h"
7 #include "base/utf_string_conversions.h" 7 #include "base/utf_string_conversions.h"
8 #include "base/values.h" 8 #include "base/values.h"
9 #include "chrome/browser/prefs/pref_service.h" 9 #include "chrome/browser/prefs/pref_service.h"
10 #include "chrome/browser/prefs/scoped_user_pref_update.h"
10 #include "chrome/common/pref_names.h" 11 #include "chrome/common/pref_names.h"
11 #include "chrome/test/testing_profile.h" 12 #include "chrome/test/testing_profile.h"
12 #include "content/browser/browser_thread.h" 13 #include "content/browser/browser_thread.h"
13 #include "content/browser/host_zoom_map.h" 14 #include "content/browser/host_zoom_map.h"
14 #include "content/common/notification_details.h" 15 #include "content/common/notification_details.h"
15 #include "content/common/notification_observer_mock.h" 16 #include "content/common/notification_observer_mock.h"
16 #include "content/common/notification_source.h" 17 #include "content/common/notification_source.h"
17 #include "content/common/notification_type.h" 18 #include "content/common/notification_type.h"
18 #include "googleurl/src/gurl.h" 19 #include "googleurl/src/gurl.h"
19 #include "testing/gmock/include/gmock/gmock.h" 20 #include "testing/gmock/include/gmock/gmock.h"
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
55 }; 56 };
56 const double HostZoomMapTest::kZoomLevel = 4; 57 const double HostZoomMapTest::kZoomLevel = 4;
57 const double HostZoomMapTest::kDefaultZoomLevel = -2; 58 const double HostZoomMapTest::kDefaultZoomLevel = -2;
58 59
59 TEST_F(HostZoomMapTest, LoadNoPrefs) { 60 TEST_F(HostZoomMapTest, LoadNoPrefs) {
60 scoped_refptr<HostZoomMap> map(new HostZoomMap(&profile_)); 61 scoped_refptr<HostZoomMap> map(new HostZoomMap(&profile_));
61 EXPECT_EQ(0, map->GetZoomLevel(url_)); 62 EXPECT_EQ(0, map->GetZoomLevel(url_));
62 } 63 }
63 64
64 TEST_F(HostZoomMapTest, Load) { 65 TEST_F(HostZoomMapTest, Load) {
65 DictionaryValue* dict = 66 {
66 prefs_->GetMutableDictionary(prefs::kPerHostZoomLevels); 67 DictionaryPrefUpdate update(prefs_, prefs::kPerHostZoomLevels);
67 dict->SetWithoutPathExpansion(host_, Value::CreateDoubleValue(kZoomLevel)); 68 DictionaryValue* dict = update.Get();
69 dict->SetWithoutPathExpansion(host_, Value::CreateDoubleValue(kZoomLevel));
70 }
68 scoped_refptr<HostZoomMap> map(new HostZoomMap(&profile_)); 71 scoped_refptr<HostZoomMap> map(new HostZoomMap(&profile_));
69 EXPECT_EQ(kZoomLevel, map->GetZoomLevel(url_)); 72 EXPECT_EQ(kZoomLevel, map->GetZoomLevel(url_));
70 } 73 }
71 74
72 TEST_F(HostZoomMapTest, SetZoomLevel) { 75 TEST_F(HostZoomMapTest, SetZoomLevel) {
73 scoped_refptr<HostZoomMap> map(new HostZoomMap(&profile_)); 76 scoped_refptr<HostZoomMap> map(new HostZoomMap(&profile_));
74 PrefChangeRegistrar registrar; 77 PrefChangeRegistrar registrar;
75 registrar.Init(prefs_); 78 registrar.Init(prefs_);
76 registrar.Add(prefs::kPerHostZoomLevels, &pref_observer_); 79 registrar.Add(prefs::kPerHostZoomLevels, &pref_observer_);
77 SetPrefObserverExpectation(); 80 SetPrefObserverExpectation();
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
123 EXPECT_EQ(kZoomLevel, map->GetZoomLevel(file_url1_)); 126 EXPECT_EQ(kZoomLevel, map->GetZoomLevel(file_url1_));
124 EXPECT_EQ(0, map->GetZoomLevel(file_url2_)); 127 EXPECT_EQ(0, map->GetZoomLevel(file_url2_));
125 } 128 }
126 129
127 TEST_F(HostZoomMapTest, ChangeDefaultZoomLevel) { 130 TEST_F(HostZoomMapTest, ChangeDefaultZoomLevel) {
128 FundamentalValue zoom_level(kDefaultZoomLevel); 131 FundamentalValue zoom_level(kDefaultZoomLevel);
129 prefs_->Set(prefs::kDefaultZoomLevel, zoom_level); 132 prefs_->Set(prefs::kDefaultZoomLevel, zoom_level);
130 scoped_refptr<HostZoomMap> map(new HostZoomMap(&profile_)); 133 scoped_refptr<HostZoomMap> map(new HostZoomMap(&profile_));
131 EXPECT_EQ(kDefaultZoomLevel, map->GetZoomLevel(url_)); 134 EXPECT_EQ(kDefaultZoomLevel, map->GetZoomLevel(url_));
132 } 135 }
OLDNEW
« no previous file with comments | « content/browser/host_zoom_map.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698