Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issue 671963002: Add first-letter range layout test. (Closed)

Created:
6 years, 2 months ago by dsinclair
Modified:
6 years, 2 months ago
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Add first-letter range layout test. BUG=425008 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184220

Patch Set 1 #

Patch Set 2 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -0 lines) Patch
M LayoutTests/TestExpectations View 1 1 chunk +2 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/first-letter-range-insert.html View 1 chunk +32 lines, -0 lines 2 comments Download

Messages

Total messages: 7 (2 generated)
dsinclair
PTAL. This is a reduction of a CRASH with first-letter pseudo elements, the test is ...
6 years, 2 months ago (2014-10-22 17:54:31 UTC) #2
Xianzhu
lgtm https://codereview.chromium.org/671963002/diff/20001/LayoutTests/fast/css/first-letter-range-insert.html File LayoutTests/fast/css/first-letter-range-insert.html (right): https://codereview.chromium.org/671963002/diff/20001/LayoutTests/fast/css/first-letter-range-insert.html#newcode23 LayoutTests/fast/css/first-letter-range-insert.html:23: <!-- Passes if no CRASH in debug. --> ...
6 years, 2 months ago (2014-10-22 17:57:34 UTC) #3
dsinclair
https://codereview.chromium.org/671963002/diff/20001/LayoutTests/fast/css/first-letter-range-insert.html File LayoutTests/fast/css/first-letter-range-insert.html (right): https://codereview.chromium.org/671963002/diff/20001/LayoutTests/fast/css/first-letter-range-insert.html#newcode23 LayoutTests/fast/css/first-letter-range-insert.html:23: <!-- Passes if no CRASH in debug. --> On ...
6 years, 2 months ago (2014-10-22 20:04:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/671963002/20001
6 years, 2 months ago (2014-10-22 20:05:38 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-22 21:06:57 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 184220

Powered by Google App Engine
This is Rietveld 408576698