chrome/browser/extensions/permissions_based_management_policy_provider.cc - Issue 671943003: Add update url controlled extension management settings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/permissions_based_management_policy_provider.cc

Issue 671943003: Add update url controlled extension management settings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ext-5

Patch Set: add unit tests Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/extension_management_unittest.cc ('K') | « chrome/browser/extensions/extension_service.cc ('k') | chrome/browser/extensions/standard_management_policy_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/permissions_based_management_policy_provider.cc

diff --git a/chrome/browser/extensions/permissions_based_management_policy_provider.cc b/chrome/browser/extensions/permissions_based_management_policy_provider.cc

index 4b299455a30f9b7e1ab32f6bc9cf71f2ba0d2380..57fa45aa0394351a8488267d6b29056ec7d4f29d 100644

--- a/chrome/browser/extensions/permissions_based_management_policy_provider.cc

+++ b/chrome/browser/extensions/permissions_based_management_policy_provider.cc

@@ -44,8 +44,7 @@ bool PermissionsBasedManagementPolicyProvider::UserMayLoad(

scoped_refptr<const PermissionSet> required_permissions =

PermissionsParser::GetRequiredPermissions(extension);

- if (!settings_->IsPermissionSetAllowed(extension->id(),

- required_permissions)) {

+ if (!settings_->IsPermissionSetAllowed(extension, required_permissions)) {

if (error) {

*error =

l10n_util::GetStringFUTF16(IDS_EXTENSION_CANT_INSTALL_POLICY_BLOCKED,