Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 671913006: DevTools: Fix frontend compilation errors uncovered by r184188 (Closed)

Created:
6 years, 1 month ago by apavlov
Modified:
6 years, 1 month ago
Reviewers:
dgozman, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: Fix frontend compilation errors uncovered by r184188 R=dgozman@chromium.org, pfeldman@chromium.org, dgozman Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184240

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -30 lines) Patch
M Source/devtools/devtools.gypi View 2 chunks +1 line, -1 line 0 comments Download
A + Source/devtools/front_end/host/ToolboxHost.js View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/host/module.json View 1 chunk +1 line, -0 lines 0 comments Download
M Source/devtools/front_end/main/AdvancedApp.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/timeline/TracingTimelineModel.js View 2 chunks +5 lines, -0 lines 0 comments Download
D Source/devtools/front_end/toolbox/ToolboxDelegate.js View 1 chunk +0 lines, -20 lines 0 comments Download
M Source/devtools/front_end/toolbox/module.json View 1 chunk +0 lines, -1 line 0 comments Download
M Source/devtools/front_end/toolbox_bootstrap/Toolbox.js View 2 chunks +18 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
apavlov
6 years, 1 month ago (2014-10-23 07:52:53 UTC) #1
pfeldman
lgtm.
6 years, 1 month ago (2014-10-23 07:55:28 UTC) #3
dgozman
lgtm
6 years, 1 month ago (2014-10-23 07:56:00 UTC) #4
apavlov
6 years, 1 month ago (2014-10-23 08:12:17 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 184240 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698