Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: LayoutTests/inspector/tracing/timeline-paint-with-layout-invalidations-on-deleted-node.html

Issue 671913005: Implement layout invalidation tracking in devtools (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/inspector/tracing/timeline-paint-with-layout-invalidations-on-deleted-node.html
diff --git a/LayoutTests/inspector/tracing/timeline-paint-with-layout-invalidations-on-deleted-node.html b/LayoutTests/inspector/tracing/timeline-paint-with-layout-invalidations-on-deleted-node.html
index 2cef7ad85cb69d7711d921a5655fe755be62b25d..54e59050cbde457c7e27e534c52ed13b54e47ecf 100644
--- a/LayoutTests/inspector/tracing/timeline-paint-with-layout-invalidations-on-deleted-node.html
+++ b/LayoutTests/inspector/tracing/timeline-paint-with-layout-invalidations-on-deleted-node.html
@@ -58,25 +58,13 @@ function test()
function testSubframe(next)
{
- var firstPaintRecord = InspectorTest.findFirstTimelineRecord(WebInspector.TimelineModel.RecordType.Paint);
- var secondPaintRecord = undefined;
-
- function findSecondPaint(record)
- {
- if (record.type() !== WebInspector.TimelineModel.RecordType.Paint)
- return false;
- if (record === firstPaintRecord)
- return false;
- secondPaintRecord = record;
- return true;
- }
- InspectorTest.timelineModel().forAllRecords(findSecondPaint);
-
// The first paint corresponds to the local frame and should have no invalidations.
+ var firstPaintRecord = InspectorTest.findFirstTimelineRecord(WebInspector.TimelineModel.RecordType.Paint);
var firstInvalidations = firstPaintRecord._event.invalidationTrackingEvents;
InspectorTest.assertEquals(firstInvalidations, undefined);
// The second paint corresponds to the subframe and should have our layout/style invalidations.
+ var secondPaintRecord = InspectorTest.findTimelineRecord(WebInspector.TimelineModel.RecordType.Paint, 1);
var secondInvalidations = secondPaintRecord._event.invalidationTrackingEvents;
InspectorTest.assertEquals(secondInvalidations.length, 3);
InspectorTest.assertEquals(secondInvalidations[0].type, WebInspector.TracingTimelineModel.RecordType.StyleRecalcInvalidationTracking);

Powered by Google App Engine
This is Rietveld 408576698