Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Unified Diff: tools/perf/metrics/speedindex.py

Issue 671913004: Telemetry: Sanitize a key and add description to speedindex metrics (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add more description Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/metrics/speedindex.py
diff --git a/tools/perf/metrics/speedindex.py b/tools/perf/metrics/speedindex.py
index bfd415842b103586fca0acef8ccddb5ba202d0d8..2daff4e5b8d21d1788b40a03d59fe1b9b2cd01b5 100644
--- a/tools/perf/metrics/speedindex.py
+++ b/tools/perf/metrics/speedindex.py
@@ -53,7 +53,23 @@ class SpeedIndexMetric(Metric):
# Release the tab so that it can be disconnected.
self._impl = None
results.AddValue(scalar.ScalarValue(
- results.current_page, '%s.speed_index' % chart_name, 'ms', index))
+ results.current_page, '%s_speed_index' % chart_name, 'ms', index,
+ description='Speed Index. This focuses on time when visible parts of '
+ 'page are displayed and shows the time when the '
+ 'first look is "almost" composed. If the contents of the '
+ 'testing page are composed by only static resources, load '
+ 'time can measure more accurately and speed index will be '
+ 'smaller than the load time. On the other hand, If the '
+ 'contents are composed by many XHR requests with small '
+ 'main resource and javascript, speed index will be able to '
+ 'get the features of performance more accurately than load '
+ 'time because the load time will measure the time when '
+ 'static resources are loaded. If you want to get more '
+ 'detail, please refer to http://goo.gl/Rw3d5d. Currently '
+ 'there are two implementations: for Android and for '
+ 'Desktop. The Android version uses video capture; the '
+ 'Desktop one uses paint events and has extra overhead to '
+ 'catch paint events.'))
def IsFinished(self, tab):
"""Decide whether the timeline recording should be stopped.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698