Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 671913004: Telemetry: Sanitize a key and add description to speedindex metrics (Closed)

Created:
6 years, 2 months ago by shimazu
Modified:
6 years, 1 month ago
Reviewers:
qyearsley
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Telemetry: Sanitize a key and add description to speedindex metrics BUG=N/A TEST=./tools/perf/run_benchmark --browser=android-chrome-shell page_cycler.top_10_mobile --pageset-repeat=1 --report-speed-index Committed: https://crrev.com/20deb3a6dc4d6b128a5eb933578922096ba1beb3 Cr-Commit-Position: refs/heads/master@{#301313}

Patch Set 1 #

Total comments: 13

Patch Set 2 : Add more description #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -1 line) Patch
M tools/perf/metrics/speedindex.py View 1 1 chunk +17 lines, -1 line 0 comments Download

Messages

Total messages: 10 (2 generated)
shimazu
PTAL
6 years, 2 months ago (2014-10-23 03:35:42 UTC) #2
qyearsley
Thanks for adding a description :-) What do you mean by 'sanitize a key'? https://codereview.chromium.org/671913004/diff/1/tools/perf/metrics/speedindex.py ...
6 years, 1 month ago (2014-10-23 17:01:40 UTC) #3
shimazu
Thanks for your reviews! "Sanitize" means '.' is changed to '_'. https://codereview.chromium.org/671913004/diff/1/tools/perf/metrics/speedindex.py File tools/perf/metrics/speedindex.py (right): ...
6 years, 1 month ago (2014-10-27 02:33:12 UTC) #4
qyearsley
LGTM, with one note -- I think that some of the explanation could be removed ...
6 years, 1 month ago (2014-10-27 02:55:47 UTC) #5
shimazu
Thanks, and I'll commit as is.
6 years, 1 month ago (2014-10-27 03:06:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/671913004/20001
6 years, 1 month ago (2014-10-27 03:06:54 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-10-27 03:59:53 UTC) #9
commit-bot: I haz the power
6 years, 1 month ago (2014-10-27 04:00:28 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/20deb3a6dc4d6b128a5eb933578922096ba1beb3
Cr-Commit-Position: refs/heads/master@{#301313}

Powered by Google App Engine
This is Rietveld 408576698