Issue 671913003: Revert of Signal WorkerThread termination earlier

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 671913003: Revert of Signal WorkerThread termination earlier (Closed)

Created:
6 years, 2 months ago by tzik

Modified:
6 years, 2 months ago

Reviewers:
haraken, sof, aandrey

CC:
blink-reviews, kinuko+worker_chromium.org, horo+watch_chromium.org, falken

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

Revert of Signal WorkerThread termination earlier (patchset #1 id:1 of https://codereview.chromium.org/667813003/) Reason for revert: This seems to cause a crash: http://crbug.com/426063 Original issue's description: > Signal WorkerThread termination earlier > > This CL resolves a race in WorkerThread::cleanup. > workerThreadTerminated() notification may release a reference to the WorkerThread instance, that causes race between the termination signal. > > BUG=405420 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184061 TBR=haraken@chromium.org,aandrey@chromium.org,sigbjornf@opera.com NOTREECHECKS=true NOTRY=true BUG=405420, 426063 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184206