Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(780)

Unified Diff: src/native_client/site_scons/site_tools/component_builders.py

Issue 6719038: Revert r4644, "Updated NaCl's build system to use SCons 2.0.1." (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client
Patch Set: Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/native_client/site_scons/site_tools/component_builders.py
diff --git a/src/native_client/site_scons/site_tools/component_builders.py b/src/native_client/site_scons/site_tools/component_builders.py
index f726919b3c86a2478e69c3608b4b68bc12f0257d..7cf78c497b08e3ba4d4f8b0e6bf5cdb124e3737f 100755
--- a/src/native_client/site_scons/site_tools/component_builders.py
+++ b/src/native_client/site_scons/site_tools/component_builders.py
@@ -124,17 +124,6 @@ def _ComponentPlatformSetup(env, builder_name, **kwargs):
for h in env['INCLUDES']:
env.Append(CCFLAGS=['${CCFLAG_INCLUDE}%s' % h])
- # This supports a NaCl convention that was previously supported with a
- # modification to SCons. Previously, EXTRA_LIBS was interpolated into LIBS
- # using the ${EXTRA_LIBS} syntax. It appears, however, that SCons naturally
- # computes library dependencies before interpolation, so EXTRA_LIBS will not
- # be correctly depended upon if interpolated. In the past, SCons was modified
- # to force interpolation before library dependencies were computed. This new
- # approach allows us to use an unmodified version of SCons.
- # In general, the use of EXTRA_LIBS is discouraged.
- if 'EXTRA_LIBS' in env:
- env['LIBS'] = env['EXTRA_LIBS'] + env['LIBS']
-
# Call platform-specific component setup function, if any
if env.get('COMPONENT_PLATFORM_SETUP'):
env['COMPONENT_PLATFORM_SETUP'](env, builder_name)
« no previous file with comments | « src/native_client/site_scons/site_init.py ('k') | src/native_client/site_scons/site_tools/target_platform_windows.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698