Issue 6719038: Revert r4644, "Updated NaCl's build system to use SCons 2.0.1."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6719038: Revert r4644, "Updated NaCl's build system to use SCons 2.0.1." (Closed)

Created:
9 years, 9 months ago by Mark Seaborn

Modified:
9 years, 5 months ago

Reviewers:
Nick Bray, robertm

CC:
native-client-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/native_client/trunk/src/native_client

Visibility:
Public.

Description

Revert r4644, "Updated NaCl's build system to use SCons 2.0.1." The change produced two failures: 1) The Windows built_elsewhere=1 bots fail with: scons: *** ('No installed VCs',) 2) The Mac toolchain buildbot fails with the following when running Scons: distutils.errors.DistutilsPlatformError: $MACOSX_DEPLOYMENT_TARGET mismatch: now "10.5" but "10.6" during configure BUG=http://code.google.com/p/nativeclient/issues/detail?id=1250 TEST=none Committed: http://src.chromium.org/viewvc/native_client?view=rev&revision=4647

Patch Set 1 #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -30 lines)			Patch
M	src/native_client/DEPS	View	2 chunks	+3 lines, -4 lines	0 comments	Download
M	src/native_client/SConstruct	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	src/native_client/scons	View	1 chunk	+2 lines, -2 lines	0 comments	Download
	src/native_client/scons.bat	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/native_client/site_scons/site_init.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/native_client/site_scons/site_tools/component_builders.py	View	1 chunk	+0 lines, -11 lines	0 comments	Download
M	src/native_client/site_scons/site_tools/target_platform_windows.py	View	3 chunks	+6 lines, -8 lines	0 comments	Download
M	src/native_client/tools/modular-build/treemappers.py	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages