Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Unified Diff: firmware/include/load_firmware_fw.h

Issue 6719005: Cherry-pick vboot_reference files from TOT to support crossystem (Closed) Base URL: ssh://git@gitrw.chromium.org:9222/vboot_reference.git@0.11.257.B
Patch Set: Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « firmware/Makefile ('k') | firmware/include/tlcl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: firmware/include/load_firmware_fw.h
diff --git a/firmware/include/load_firmware_fw.h b/firmware/include/load_firmware_fw.h
index 1e42f1c9c2fe67b91779cdcfca54ff0f033bcb04..11fb0ce701b38bcba6670153c787d08fabdc77bc 100644
--- a/firmware/include/load_firmware_fw.h
+++ b/firmware/include/load_firmware_fw.h
@@ -11,9 +11,7 @@
#include "sysincludes.h"
#include "vboot_nvstorage.h"
-
-/* Recommended size of shared_data_blob in bytes. */
-#define LOAD_FIRMWARE_SHARED_DATA_REC_SIZE 16384
+#include "vboot_struct.h"
/* Return codes for LoadFirmware() and S3Resume(). */
#define LOAD_FIRMWARE_SUCCESS 0 /* Success */
@@ -33,15 +31,19 @@ typedef struct LoadFirmwareParams {
void* verification_block_1; /* Key block + preamble for firmware 1 */
uint64_t verification_size_0; /* Verification block 0 size in bytes */
uint64_t verification_size_1; /* Verification block 1 size in bytes */
- void* shared_data_blob; /* Destination buffer for data shared between
- * LoadFirmware() and LoadKernel(). Pass this
+
+ /* Shared data blob for data shared between LoadFirmware() and LoadKernel().
+ * This should be at least VB_SHARED_DATA_MIN_SIZE bytes long, and ideally
+ * is VB_SHARED_DATA_REC_SIZE bytes long. */
+ void* shared_data_blob; /* Shared data blob buffer. Pass this
* data to LoadKernel() in
* LoadKernelParams.shared_data_blob. */
- uint64_t shared_data_size; /* Size of shared data blob buffer, in bytes.
- * On output, this will contain the actual
- * data size placed into the buffer. Caller
- * need only pass this much data to
- * LoadKernel().*/
+ uint64_t shared_data_size; /* On input, set to size of shared data blob
+ * buffer, in bytes. On output, this will
+ * contain the actual data size placed into
+ * the buffer. Caller need only pass that
+ * much data to LoadKernel().*/
+
uint64_t boot_flags; /* Boot flags */
VbNvContext* nv_context; /* Context for NV storage. nv_context->raw
* must be filled before calling
« no previous file with comments | « firmware/Makefile ('k') | firmware/include/tlcl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698