Migrates legacy packaged app data when it's upgraded to a platform app

storage/browser/fileapi/obfuscated_file_util.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "storage/browser/fileapi/obfuscated_file_util.h"
 
 #include <queue>
 #include <string>
 #include <vector>
 
@@ skipping 880 matching lines @@
 
   // No other directories seem exist. Try deleting the entire origin directory.
   InitOriginDatabase(origin, false);
   if (origin_database_) {
     origin_database_->RemovePathForOrigin(
         storage::GetIdentifierFromOrigin(origin));
   }
   return base::DeleteFile(origin_path, true /* recursive */);
 }
 
+void ObfuscatedFileUtil::CloseFileSystemForOriginAndType(
+    const GURL& origin,
+    const std::string& type_string) {
+  std::string key = GetDirectoryDatabaseKey(origin, type_string);
+  if (key.empty())
+    return;
+  DirectoryMap::iterator iter = directories_.find(key);

[cmumford, 2015/01/06 15:30:27]

I don't know this class very well, but looking at
ObfuscatedFileUtil::DestroyDirectoryDatabase() it appears that multiple keys may
match. It does a loop and this function does not. Is that required?

[ryanackley, 2015/01/12 21:18:17]

I think there was a recent change because this code was originally taken from
that method.

+  if (iter == directories_.end())
+    return;
+  scoped_ptr<SandboxDirectoryDatabase> database(iter->second);
+  directories_.erase(iter);
+}
+
 ObfuscatedFileUtil::AbstractOriginEnumerator*
 ObfuscatedFileUtil::CreateOriginEnumerator() {
   std::vector<SandboxOriginDatabase::OriginRecord> origins;
 
   InitOriginDatabase(GURL(), false);
   return new ObfuscatedOriginEnumerator(
       origin_database_.get(), file_system_directory_);
 }
 
 void ObfuscatedFileUtil::DestroyDirectoryDatabase(
@@ skipping 491 matching lines @@
   }
   return file.Pass();
 }
 
 bool ObfuscatedFileUtil::HasIsolatedStorage(const GURL& origin) {
   return special_storage_policy_.get() &&
       special_storage_policy_->HasIsolatedStorage(origin);
 }
 
 }  // namespace storage