Issue 671843003: Small fixes for the code serializer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 671843003: Small fixes for the code serializer. (Closed)

Created:
6 years, 2 months ago by Yang

Modified:
6 years, 2 months ago

Reviewers:
mvstanton

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Small fixes for the code serializer. - assertions regarding max heap object size. - ensure string table capacity upfront. R=mvstanton@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24824

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : also include fix for internalized strings #

Total comments: 1

Patch Set 4 : rebased and addressed nit #

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+47 lines, -13 lines)			Patch
M	src/objects.h	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/objects.cc	View	1 2 3	1 chunk	+10 lines, -0 lines	0 comments	Download
M	src/serialize.h	View	1 2	5 chunks	+20 lines, -9 lines	0 comments	Download
M	src/serialize.cc	View	1 2	6 chunks	+15 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

mvstanton

one nit, LGTM. https://codereview.chromium.org/671843003/diff/40001/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/671843003/diff/40001/src/objects.cc#newcode14790 src/objects.cc:14790: void StringTable::EnsureCapacityForDeserialization(Isolate* isolate, int n) { ...

6 years, 2 months ago (2014-10-23 07:29:39 UTC) #2

Yang

6 years, 2 months ago (2014-10-23 08:25:51 UTC) #3

Message was sent while issue was closed.

Committed patchset #4 (id:60001) manually as 24824 (presubmit successful).

Expand Messages | Collapse Messages