Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 671833003: Use -s to pass string date to 'adb shell date' command to set date in provision. (Closed)

Created:
6 years, 2 months ago by navabi
Modified:
6 years, 2 months ago
Reviewers:
jam, Yaron, jbudorick, zty
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Use -s to pass string date to 'adb shell date' command to set date in provision. The 'date -u' was not working on N5 devices. The -s option seems to work across devices. I've tested on N4 and N5. This change implements an earlier change that was reverted. See the change here: https://codereview.chromium.org/668013003/ The difference in this change is that it sets the time zone to UTC. BUG=406848 Committed: https://crrev.com/3fad747a3352fb78e4beaf51cbf839e72168a4cb Cr-Commit-Position: refs/heads/master@{#300803}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Use time.gmtime() instead of setting env var 'TZ'. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M build/android/provision_devices.py View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 12 (2 generated)
navabi
Added jam@ in case he has any ideas on how to test this on the ...
6 years, 2 months ago (2014-10-22 08:26:02 UTC) #2
navabi
> Do manually triggered try jobs also use analyze? I answered that by doing a ...
6 years, 2 months ago (2014-10-22 08:34:24 UTC) #3
jbudorick
On 2014/10/22 08:34:24, navabi wrote: > > Do manually triggered try jobs also use analyze? ...
6 years, 2 months ago (2014-10-22 15:47:03 UTC) #4
jbudorick
https://codereview.chromium.org/671833003/diff/1/build/android/provision_devices.py File build/android/provision_devices.py (right): https://codereview.chromium.org/671833003/diff/1/build/android/provision_devices.py#newcode196 build/android/provision_devices.py:196: device.RunShellCommand('date -s %s' % time.strftime('%Y%m%d.%I%M%S'), Can you just do ...
6 years, 2 months ago (2014-10-22 15:52:11 UTC) #5
navabi
Thanks for the suggestion jbudorick. PTAL. https://codereview.chromium.org/671833003/diff/1/build/android/provision_devices.py File build/android/provision_devices.py (right): https://codereview.chromium.org/671833003/diff/1/build/android/provision_devices.py#newcode196 build/android/provision_devices.py:196: device.RunShellCommand('date -s %s' ...
6 years, 2 months ago (2014-10-22 16:17:35 UTC) #6
jbudorick
change lgtm, but it'd be nice to have the trybot coverage in place before landing.
6 years, 2 months ago (2014-10-22 19:06:30 UTC) #7
navabi
On 2014/10/22 19:06:30, jbudorick wrote: > change lgtm, but it'd be nice to have the ...
6 years, 2 months ago (2014-10-22 20:19:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/671833003/20001
6 years, 2 months ago (2014-10-22 22:47:53 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 2 months ago (2014-10-23 00:03:12 UTC) #11
commit-bot: I haz the power
6 years, 2 months ago (2014-10-23 00:04:08 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3fad747a3352fb78e4beaf51cbf839e72168a4cb
Cr-Commit-Position: refs/heads/master@{#300803}

Powered by Google App Engine
This is Rietveld 408576698