Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 671813002: Use the stateless GC::fillRect variant when possible. (Closed)

Created:
6 years, 2 months ago by f(malita)
Modified:
6 years, 2 months ago
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, mkwst+moarreviews_chromium.org, pdr+renderingwatchlist_chromium.org, rune+blink, zoltan1
Project:
blink
Visibility:
Public.

Description

Use the stateless GC::fillRect variant when possible. This reduces deferred paint save pressure and allows us to remove a couple of GC state savers. R=schenney@chromium.org,senorblanco@chromium.org TBR=esprehn@chromium.org BUG=424655 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184318

Patch Set 1 #

Patch Set 2 : minor LayerPainter update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -16 lines) Patch
M Source/core/paint/LayerPainter.cpp View 1 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/rendering/RenderTheme.cpp View 2 chunks +1 line, -3 lines 0 comments Download
M Source/platform/scroll/ScrollbarThemeNonMacCommon.cpp View 1 chunk +2 lines, -4 lines 0 comments Download
M Source/web/WebLocalFrameImpl.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M Source/web/WebPluginContainerImpl.cpp View 1 chunk +3 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
f(malita)
6 years, 2 months ago (2014-10-22 01:02:17 UTC) #1
Stephen White
LGTM
6 years, 2 months ago (2014-10-22 15:21:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/671813002/20001
6 years, 2 months ago (2014-10-22 17:27:58 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/18087)
6 years, 2 months ago (2014-10-22 18:12:00 UTC) #6
f(malita)
On 2014/10/22 18:12:00, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 2 months ago (2014-10-22 18:24:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/671813002/20001
6 years, 2 months ago (2014-10-24 00:30:00 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 184318
6 years, 2 months ago (2014-10-24 00:35:11 UTC) #11
esprehn
6 years, 2 months ago (2014-10-24 00:36:27 UTC) #12
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698