Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Unified Diff: content/renderer/media/webrtc/webrtc_local_audio_track_adapter.cc

Issue 671793004: Clean up the media stream audio track code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/webrtc/webrtc_local_audio_track_adapter.cc
diff --git a/content/renderer/media/webrtc/webrtc_local_audio_track_adapter.cc b/content/renderer/media/webrtc/webrtc_local_audio_track_adapter.cc
index 96b683785d1e36cbc1cfbb0e57dc1bf9806cc086..b18f7eedbfe14b7ef9188390bbe092d8c70af280 100644
--- a/content/renderer/media/webrtc/webrtc_local_audio_track_adapter.cc
+++ b/content/renderer/media/webrtc/webrtc_local_audio_track_adapter.cc
@@ -89,11 +89,6 @@ bool WebRtcLocalAudioTrackAdapter::GetSignalLevel(int* level) {
// It is required to provide the signal level after audio processing. In
// case the audio processing is not enabled for the track, we return
// false here in order not to overwrite the value from WebRTC.
- // TODO(xians): Remove this after we turn on the APM in Chrome by default.
- // http://crbug/365672 .
- if (!MediaStreamAudioProcessor::IsAudioTrackProcessingEnabled())
- return false;
-
*level = signal_level_;
return true;
}
@@ -143,16 +138,7 @@ webrtc::AudioSourceInterface* WebRtcLocalAudioTrackAdapter::GetSource() const {
}
cricket::AudioRenderer* WebRtcLocalAudioTrackAdapter::GetRenderer() {
- // When the audio track processing is enabled, return a NULL so that capture
- // data goes through Libjingle LocalAudioTrackHandler::LocalAudioSinkAdapter
- // ==> WebRtcVoiceMediaChannel::WebRtcVoiceChannelRenderer ==> WebRTC.
- // When the audio track processing is disabled, WebRtcLocalAudioTrackAdapter
- // is used to pass the channel ids to WebRtcAudioDeviceImpl, the data flow
- // becomes WebRtcAudioDeviceImpl ==> WebRTC.
- // TODO(xians): Only return NULL after the APM in WebRTC is deprecated.
- // See See http://crbug/365672 for details.
- return MediaStreamAudioProcessor::IsAudioTrackProcessingEnabled()?
- NULL : this;
+ return NULL;
tommi (sloooow) - chröme 2014/10/30 14:10:06 NOTREACHED()?
no longer working on chromium 2014/10/30 14:13:31 We can't. mediastreamhandler.cc still calls it tod
}
} // namespace content

Powered by Google App Engine
This is Rietveld 408576698