Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 671793004: Clean up the media stream audio track code (Closed)

Created:
6 years, 2 months ago by no longer working on chromium
Modified:
6 years, 1 month ago
CC:
chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, davemoore+watch_chromium.org, feature-media-reviews_chromium.org, jam, mcasas+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, nasko+codewatch_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org, posciak+watch_chromium.org, stevenjb+watch_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Clean up the media stream audio track code. With the deprecation of APM in WebRTC, we are able to remove lots of legacy and hacky code in Chrome. What this CL does is removing most of the dead code related to APM in WebRTC. BUG=425956 TEST=bots. R=avi@chromium.org, jochen@chromium.org, tommi@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/b19cd364004b235107de4331d2de23669150a5de

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebased #

Patch Set 3 : fixed the compilation. #

Patch Set 4 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -767 lines) Patch
M chrome/browser/chromeos/login/chrome_restart_request.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M content/content_renderer.gypi View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M content/public/common/content_switches.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_switches.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
M content/renderer/media/media_stream_audio_processor.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M content/renderer/media/media_stream_audio_processor.cc View 1 2 3 4 chunks +7 lines, -20 lines 0 comments Download
M content/renderer/media/media_stream_audio_processor_options.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M content/renderer/media/media_stream_audio_processor_options.cc View 1 2 3 1 chunk +0 lines, -19 lines 0 comments Download
M content/renderer/media/media_stream_audio_processor_unittest.cc View 4 chunks +0 lines, -55 lines 0 comments Download
M content/renderer/media/media_stream_audio_sink_owner.h View 1 chunk +4 lines, -10 lines 0 comments Download
M content/renderer/media/media_stream_audio_sink_owner.cc View 2 chunks +4 lines, -19 lines 0 comments Download
M content/renderer/media/media_stream_audio_track_sink.h View 3 chunks +2 lines, -17 lines 0 comments Download
D content/renderer/media/peer_connection_audio_sink_owner.h View 1 chunk +0 lines, -54 lines 0 comments Download
D content/renderer/media/peer_connection_audio_sink_owner.cc View 1 chunk +0 lines, -71 lines 0 comments Download
M content/renderer/media/speech_recognition_audio_sink_unittest.cc View 1 2 3 1 chunk +1 line, -3 lines 0 comments Download
M content/renderer/media/webaudio_capturer_source.h View 3 chunks +1 line, -7 lines 0 comments Download
M content/renderer/media/webaudio_capturer_source.cc View 4 chunks +2 lines, -20 lines 0 comments Download
M content/renderer/media/webrtc/peer_connection_dependency_factory.h View 1 3 chunks +1 line, -14 lines 0 comments Download
M content/renderer/media/webrtc/peer_connection_dependency_factory.cc View 1 2 3 4 chunks +0 lines, -45 lines 0 comments Download
M content/renderer/media/webrtc/webrtc_local_audio_track_adapter.cc View 1 2 chunks +1 line, -18 lines 0 comments Download
M content/renderer/media/webrtc/webrtc_local_audio_track_adapter_unittest.cc View 1 3 chunks +3 lines, -9 lines 0 comments Download
M content/renderer/media/webrtc_audio_capturer.h View 2 chunks +0 lines, -13 lines 0 comments Download
M content/renderer/media/webrtc_audio_capturer.cc View 1 2 3 8 chunks +3 lines, -37 lines 0 comments Download
M content/renderer/media/webrtc_audio_capturer_unittest.cc View 6 chunks +10 lines, -52 lines 0 comments Download
M content/renderer/media/webrtc_audio_device_impl.h View 1 4 chunks +1 line, -54 lines 0 comments Download
M content/renderer/media/webrtc_audio_device_impl.cc View 1 4 chunks +15 lines, -107 lines 0 comments Download
M content/renderer/media/webrtc_local_audio_track.h View 1 4 chunks +2 lines, -14 lines 0 comments Download
M content/renderer/media/webrtc_local_audio_track.cc View 1 5 chunks +4 lines, -53 lines 0 comments Download
M content/renderer/media/webrtc_local_audio_track_unittest.cc View 1 10 chunks +16 lines, -39 lines 0 comments Download

Messages

Total messages: 29 (11 generated)
no longer working on chromium
Hi guys, this CL removes dead code. Tommi, please review media/ Jochen, owner stamp for ...
6 years, 2 months ago (2014-10-22 11:28:17 UTC) #2
no longer working on chromium
ping
6 years, 2 months ago (2014-10-24 08:46:21 UTC) #3
tommi (sloooow) - chröme
lgtm https://codereview.chromium.org/671793004/diff/1/content/renderer/media/webrtc/webrtc_local_audio_track_adapter.cc File content/renderer/media/webrtc/webrtc_local_audio_track_adapter.cc (right): https://codereview.chromium.org/671793004/diff/1/content/renderer/media/webrtc/webrtc_local_audio_track_adapter.cc#newcode141 content/renderer/media/webrtc/webrtc_local_audio_track_adapter.cc:141: return NULL; NOTREACHED()?
6 years, 1 month ago (2014-10-30 14:10:06 UTC) #4
no longer working on chromium
https://codereview.chromium.org/671793004/diff/1/content/renderer/media/webrtc/webrtc_local_audio_track_adapter.cc File content/renderer/media/webrtc/webrtc_local_audio_track_adapter.cc (right): https://codereview.chromium.org/671793004/diff/1/content/renderer/media/webrtc/webrtc_local_audio_track_adapter.cc#newcode141 content/renderer/media/webrtc/webrtc_local_audio_track_adapter.cc:141: return NULL; On 2014/10/30 14:10:06, tommi wrote: > NOTREACHED()? ...
6 years, 1 month ago (2014-10-30 14:13:31 UTC) #5
no longer working on chromium
+avi since jochen is out. avi, could you please stamp the changes in chrome/browser/chromeos/login/chrome_restart_request.cc content/browser/renderer_host/render_process_host_impl.cc ...
6 years, 1 month ago (2014-10-30 14:15:31 UTC) #7
Avi (use Gerrit)
On 2014/10/30 14:15:31, xians1 wrote: > +avi since jochen is out. > > avi, could ...
6 years, 1 month ago (2014-10-30 14:47:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/671793004/1
6 years, 1 month ago (2014-10-30 14:53:56 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/21230) linux_chromium_asan_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel/builds/7493) win_chromium_x64_rel_ng ...
6 years, 1 month ago (2014-10-30 14:57:29 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/671793004/20001
6 years, 1 month ago (2014-11-11 14:08:14 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/23450)
6 years, 1 month ago (2014-11-11 14:11:49 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/671793004/40001
6 years, 1 month ago (2014-11-12 08:42:59 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/23647)
6 years, 1 month ago (2014-11-12 08:47:51 UTC) #20
jochen (gone - plz use gerrit)
lgtm
6 years, 1 month ago (2014-11-12 14:52:17 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/671793004/40001
6 years, 1 month ago (2014-11-14 13:56:08 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/24216)
6 years, 1 month ago (2014-11-14 13:59:57 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/671793004/60001
6 years, 1 month ago (2014-11-17 14:40:44 UTC) #27
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/b19cd364004b235107de4331d2de23669150a5de Cr-Commit-Position: refs/heads/master@{#304424}
6 years, 1 month ago (2014-11-17 15:22:40 UTC) #28
no longer working on chromium
6 years, 1 month ago (2014-11-17 15:22:54 UTC) #29
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as b19cd36 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698