chrome/browser/ui/webui/extensions/extension_settings_handler.cc - Issue 671763002: Extract ProcessManager from ExtensionSystem.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/extensions/extension_settings_handler.cc

Issue 671763002: Extract ProcessManager from ExtensionSystem. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased. Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/extensions/extension_settings_handler.cc

diff --git a/chrome/browser/ui/webui/extensions/extension_settings_handler.cc b/chrome/browser/ui/webui/extensions/extension_settings_handler.cc

index bc97cf2029e52a3cee2abf3f96ac5031d49c923b..f4cb96192c9706c52b5d8c31a24ac7997ade5b4b 100644

--- a/chrome/browser/ui/webui/extensions/extension_settings_handler.cc

+++ b/chrome/browser/ui/webui/extensions/extension_settings_handler.cc

@@ -1371,7 +1371,7 @@ ExtensionSettingsHandler::GetInspectablePagesForExtension(

// Get the extension process's active views.

extensions::ProcessManager* process_manager =

- ExtensionSystem::Get(extension_service_->profile())->process_manager();

+ ProcessManager::Get(extension_service_->profile());

GetInspectablePagesForExtensionProcess(

extension,

process_manager->GetRenderViewHostsForExtension(extension->id()),

@@ -1399,9 +1399,8 @@ ExtensionSettingsHandler::GetInspectablePagesForExtension(

IncognitoInfo::IsSplitMode(extension) &&

util::IsIncognitoEnabled(extension->id(),

extension_service_->profile())) {

- extensions::ProcessManager* process_manager =

- ExtensionSystem::Get(extension_service_->profile()->

- GetOffTheRecordProfile())->process_manager();

+ extensions::ProcessManager* process_manager = ProcessManager::Get(

+ extension_service_->profile()->GetOffTheRecordProfile());

GetInspectablePagesForExtensionProcess(

extension,

process_manager->GetRenderViewHostsForExtension(extension->id()),