Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 67173009: Adding new fuzzer deserialization test code (Closed)

Created:
7 years, 1 month ago by sugoi1
Modified:
7 years, 1 month ago
CC:
chromium-reviews
Visibility:
Public.

Description

Adding new fuzzer deserialization test code BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235846

Patch Set 1 #

Total comments: 1

Patch Set 2 : Added rendering code #

Total comments: 6

Patch Set 3 : Adding filter_fuzz_stub to chromium_builder_asan #

Patch Set 4 : Added logging.h #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -0 lines) Patch
M build/all.gyp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M skia/skia.gyp View 1 2 1 chunk +11 lines, -0 lines 0 comments Download
A skia/tools/filter_fuzz_stub/filter_fuzz_stub.cc View 1 2 3 1 chunk +93 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
sugoi1
Here's a 1st version. It's really simple. Is this what you guys had in mind ...
7 years, 1 month ago (2013-11-13 19:34:36 UTC) #1
mbarbella (wrong one)
https://codereview.chromium.org/67173009/diff/1/skia/tools/filter_fuzz_stub/filter_fuzz_stub.cc File skia/tools/filter_fuzz_stub/filter_fuzz_stub.cc (right): https://codereview.chromium.org/67173009/diff/1/skia/tools/filter_fuzz_stub/filter_fuzz_stub.cc#newcode27 skia/tools/filter_fuzz_stub/filter_fuzz_stub.cc:27: SkImageFilter::GetFlattenableType()); Once this is done, try to render something ...
7 years, 1 month ago (2013-11-13 20:02:56 UTC) #2
sugoi1
Added rendering code
7 years, 1 month ago (2013-11-13 20:56:47 UTC) #3
mbarbella (wrong one)
lgtm https://codereview.chromium.org/67173009/diff/60001/skia/tools/filter_fuzz_stub/filter_fuzz_stub.cc File skia/tools/filter_fuzz_stub/filter_fuzz_stub.cc (right): https://codereview.chromium.org/67173009/diff/60001/skia/tools/filter_fuzz_stub/filter_fuzz_stub.cc#newcode76 skia/tools/filter_fuzz_stub/filter_fuzz_stub.cc:76: bitmap.setConfig(SkBitmap::kARGB_8888_Config, BitmapSize, BitmapSize); Minor thing. Could we only ...
7 years, 1 month ago (2013-11-13 21:08:11 UTC) #4
sugoi1
https://codereview.chromium.org/67173009/diff/60001/skia/tools/filter_fuzz_stub/filter_fuzz_stub.cc File skia/tools/filter_fuzz_stub/filter_fuzz_stub.cc (right): https://codereview.chromium.org/67173009/diff/60001/skia/tools/filter_fuzz_stub/filter_fuzz_stub.cc#newcode76 skia/tools/filter_fuzz_stub/filter_fuzz_stub.cc:76: bitmap.setConfig(SkBitmap::kARGB_8888_Config, BitmapSize, BitmapSize); On 2013/11/13 21:08:11, mbarbella1 wrote: > ...
7 years, 1 month ago (2013-11-13 21:17:00 UTC) #5
sugoi1
Adding robertphillips@ as a reviewer to get some input from a Skia dev.
7 years, 1 month ago (2013-11-13 21:17:53 UTC) #6
mbarbella (wrong one)
On 2013/11/13 21:17:00, sugoi1 wrote: > https://codereview.chromium.org/67173009/diff/60001/skia/tools/filter_fuzz_stub/filter_fuzz_stub.cc > File skia/tools/filter_fuzz_stub/filter_fuzz_stub.cc (right): > > https://codereview.chromium.org/67173009/diff/60001/skia/tools/filter_fuzz_stub/filter_fuzz_stub.cc#newcode76 > ...
7 years, 1 month ago (2013-11-13 21:18:33 UTC) #7
robertphillips
https://codereview.chromium.org/67173009/diff/60001/skia/tools/filter_fuzz_stub/filter_fuzz_stub.cc File skia/tools/filter_fuzz_stub/filter_fuzz_stub.cc (right): https://codereview.chromium.org/67173009/diff/60001/skia/tools/filter_fuzz_stub/filter_fuzz_stub.cc#newcode45 skia/tools/filter_fuzz_stub/filter_fuzz_stub.cc:45: // If nothing bad happens within this call, everything ...
7 years, 1 month ago (2013-11-14 14:32:04 UTC) #8
sugoi1
https://codereview.chromium.org/67173009/diff/60001/skia/tools/filter_fuzz_stub/filter_fuzz_stub.cc File skia/tools/filter_fuzz_stub/filter_fuzz_stub.cc (right): https://codereview.chromium.org/67173009/diff/60001/skia/tools/filter_fuzz_stub/filter_fuzz_stub.cc#newcode45 skia/tools/filter_fuzz_stub/filter_fuzz_stub.cc:45: // If nothing bad happens within this call, everything ...
7 years, 1 month ago (2013-11-14 15:08:46 UTC) #9
robertphillips
https://codereview.chromium.org/67173009/diff/60001/skia/tools/filter_fuzz_stub/filter_fuzz_stub.cc File skia/tools/filter_fuzz_stub/filter_fuzz_stub.cc (right): https://codereview.chromium.org/67173009/diff/60001/skia/tools/filter_fuzz_stub/filter_fuzz_stub.cc#newcode45 skia/tools/filter_fuzz_stub/filter_fuzz_stub.cc:45: // If nothing bad happens within this call, everything ...
7 years, 1 month ago (2013-11-14 15:11:53 UTC) #10
sugoi1
filter_fuzz_stub is now built when compiling chromium_builder_asan.
7 years, 1 month ago (2013-11-18 16:46:49 UTC) #11
Stephen White
LGTM
7 years, 1 month ago (2013-11-18 18:37:13 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sugoi@chromium.org/67173009/240001
7 years, 1 month ago (2013-11-18 20:44:50 UTC) #13
commit-bot: I haz the power
7 years, 1 month ago (2013-11-18 23:35:24 UTC) #14
Message was sent while issue was closed.
Change committed as 235846

Powered by Google App Engine
This is Rietveld 408576698