Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 67173007: Add more unit tests for JS bindings to Core (Closed)

Created:
7 years, 1 month ago by abarth-chromium
Modified:
7 years, 1 month ago
Reviewers:
Aaron Boodman
CC:
chromium-reviews, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org
Visibility:
Public.

Description

Add more unit tests for JS bindings to Core This CL adds core_unittests.js, which tests basic functionality in the JavaScript bindings for Mojo's core messaging APIs. R=aa@chromium.org BUG=317398 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=234460

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -4 lines) Patch
M mojo/mojo.gyp View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/bindings/js/core.cc View 3 chunks +55 lines, -2 lines 1 comment Download
A mojo/public/bindings/js/core_unittests.js View 1 chunk +57 lines, -0 lines 0 comments Download
M mojo/public/bindings/js/test/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/public/bindings/js/test/harness.cc View 3 chunks +11 lines, -1 line 0 comments Download
A + mojo/public/bindings/js/test/run_all_unittests.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
abarth-chromium
7 years, 1 month ago (2013-11-12 00:31:52 UTC) #1
abarth-chromium
We clearly need a better unit testing system for our JavaScript code. If we use ...
7 years, 1 month ago (2013-11-12 00:33:12 UTC) #2
Aaron Boodman
Yeah, so unit testing was one motivation for why the extension binding system uses modules, ...
7 years, 1 month ago (2013-11-12 01:56:16 UTC) #3
Aaron Boodman
(lgtm)
7 years, 1 month ago (2013-11-12 05:51:00 UTC) #4
abarth-chromium
On 2013/11/12 01:56:16, Aaron Boodman wrote: > Yeah, so unit testing was one motivation for ...
7 years, 1 month ago (2013-11-12 06:25:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/67173007/1
7 years, 1 month ago (2013-11-12 06:27:48 UTC) #6
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 1 month ago (2013-11-12 07:13:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/67173007/1
7 years, 1 month ago (2013-11-12 07:24:35 UTC) #8
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 1 month ago (2013-11-12 07:48:46 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/67173007/1
7 years, 1 month ago (2013-11-12 07:56:00 UTC) #10
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 1 month ago (2013-11-12 08:21:01 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/67173007/1
7 years, 1 month ago (2013-11-12 08:27:33 UTC) #12
commit-bot: I haz the power
7 years, 1 month ago (2013-11-12 08:36:59 UTC) #13
Message was sent while issue was closed.
Change committed as 234460

Powered by Google App Engine
This is Rietveld 408576698