Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 671713006: Make parseCompositeAndBlendOperator() take care of "normal". (Closed)

Created:
6 years, 2 months ago by dshwang
Modified:
6 years, 2 months ago
CC:
blink-reviews, krit, Rik, jbroman, mkwst+moarreviews_chromium.org, danakj, pdr+graphicswatchlist_chromium.org, Stephen Chennney, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Make parseCompositeAndBlendOperator() take care of "normal". Currently, parseCompositeAndBlendOperator() doesn't recognize "normal". Fortunately, there are not bugs because all clients set blend mode to "normal" if this function fails. BUG=425656 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184239

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix ASSERT, remove stale comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -6 lines) Patch
M Source/platform/graphics/GraphicsTypes.cpp View 1 3 chunks +3 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
dshwang
could you review this simple CL?
6 years, 2 months ago (2014-10-22 10:21:06 UTC) #2
Justin Novosad
https://codereview.chromium.org/671713006/diff/1/Source/platform/graphics/GraphicsTypes.cpp File Source/platform/graphics/GraphicsTypes.cpp (right): https://codereview.chromium.org/671713006/diff/1/Source/platform/graphics/GraphicsTypes.cpp#newcode101 Source/platform/graphics/GraphicsTypes.cpp:101: ASSERT(blendOp <= numBlendOperatorNames); This assert is now a tautology. ...
6 years, 2 months ago (2014-10-22 15:22:39 UTC) #3
dshwang
Thank you for review. I addressed ASSERT and removed stale comments. On 2014/10/22 15:22:39, junov ...
6 years, 2 months ago (2014-10-22 16:42:53 UTC) #4
Justin Novosad
lgtm
6 years, 2 months ago (2014-10-22 20:23:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/671713006/20001
6 years, 2 months ago (2014-10-23 07:13:10 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-23 07:43:05 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as 184239

Powered by Google App Engine
This is Rietveld 408576698