Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1750)

Unified Diff: content/shell/renderer/test_runner/test_runner.h

Issue 671663002: Standardize usage of virtual/override/final in content/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/shell/renderer/test_runner/test_plugin.h ('k') | content/shell/renderer/test_runner/test_runner.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/shell/renderer/test_runner/test_runner.h
diff --git a/content/shell/renderer/test_runner/test_runner.h b/content/shell/renderer/test_runner/test_runner.h
index 2fb5dc31622e9302d7ffb2c98aa9e2f55a8030a1..3abed94598f3d42b48d00328148f405ec237da0a 100644
--- a/content/shell/renderer/test_runner/test_runner.h
+++ b/content/shell/renderer/test_runner/test_runner.h
@@ -65,12 +65,11 @@ class TestRunner : public WebTestRunner,
void InvokeCallback(scoped_ptr<InvokeCallbackTask> callback);
// WebTestRunner implementation.
- virtual bool ShouldGeneratePixelResults() override;
- virtual bool ShouldDumpAsAudio() const override;
- virtual void GetAudioData(
- std::vector<unsigned char>* buffer_view) const override;
- virtual bool ShouldDumpBackForwardList() const override;
- virtual blink::WebPermissionClient* GetWebPermissions() const override;
+ bool ShouldGeneratePixelResults() override;
+ bool ShouldDumpAsAudio() const override;
+ void GetAudioData(std::vector<unsigned char>* buffer_view) const override;
+ bool ShouldDumpBackForwardList() const override;
+ blink::WebPermissionClient* GetWebPermissions() const override;
// Methods used by WebTestProxyBase.
bool shouldDumpSelectionRect() const;
@@ -164,7 +163,7 @@ class TestRunner : public WebTestRunner,
public:
WorkQueueTask(WorkQueue* object) : WebMethodTask<WorkQueue>(object) {}
- virtual void RunIfValid() override;
+ void RunIfValid() override;
};
WebTaskList task_list_;
« no previous file with comments | « content/shell/renderer/test_runner/test_plugin.h ('k') | content/shell/renderer/test_runner/test_runner.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698