Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Unified Diff: content/shell/renderer/test_runner/event_sender.cc

Issue 671663002: Standardize usage of virtual/override/final in content/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/shell/renderer/test_runner/event_sender.cc
diff --git a/content/shell/renderer/test_runner/event_sender.cc b/content/shell/renderer/test_runner/event_sender.cc
index 7a2b07f17e77c4feadaa9473187deccdc414f017..dc8e47383a1e86f0f8d74981de708f909335f226 100644
--- a/content/shell/renderer/test_runner/event_sender.cc
+++ b/content/shell/renderer/test_runner/event_sender.cc
@@ -233,9 +233,7 @@ class MouseDownTask : public WebMethodTask<EventSender> {
button_number_(button_number),
modifiers_(modifiers) {}
- virtual void RunIfValid() override {
- object_->MouseDown(button_number_, modifiers_);
- }
+ void RunIfValid() override { object_->MouseDown(button_number_, modifiers_); }
private:
int button_number_;
@@ -249,9 +247,7 @@ class MouseUpTask : public WebMethodTask<EventSender> {
button_number_(button_number),
modifiers_(modifiers) {}
- virtual void RunIfValid() override {
- object_->MouseUp(button_number_, modifiers_);
- }
+ void RunIfValid() override { object_->MouseUp(button_number_, modifiers_); }
private:
int button_number_;
@@ -269,7 +265,7 @@ class KeyDownTask : public WebMethodTask<EventSender> {
modifiers_(modifiers),
location_(location) {}
- virtual void RunIfValid() override {
+ void RunIfValid() override {
object_->KeyDown(code_str_, modifiers_, location_);
}
@@ -344,10 +340,10 @@ class EventSenderBindings : public gin::Wrappable<EventSenderBindings> {
private:
explicit EventSenderBindings(base::WeakPtr<EventSender> sender);
- virtual ~EventSenderBindings();
+ ~EventSenderBindings() override;
// gin::Wrappable:
- virtual gin::ObjectTemplateBuilder GetObjectTemplateBuilder(
+ gin::ObjectTemplateBuilder GetObjectTemplateBuilder(
v8::Isolate* isolate) override;
// Bound methods:

Powered by Google App Engine
This is Rietveld 408576698