Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Side by Side Diff: content/public/browser/download_item.h

Issue 671663002: Standardize usage of virtual/override/final in content/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // Each download is represented by a DownloadItem, and all DownloadItems 5 // Each download is represented by a DownloadItem, and all DownloadItems
6 // are owned by the DownloadManager which maintains a global list of all 6 // are owned by the DownloadManager which maintains a global list of all
7 // downloads. DownloadItems are created when a user initiates a download, 7 // downloads. DownloadItems are created when a user initiates a download,
8 // and exist for the duration of the browser life time. 8 // and exist for the duration of the browser life time.
9 // 9 //
10 // Download observers: 10 // Download observers:
(...skipping 81 matching lines...) Expand 10 before | Expand all | Expand 10 after
92 92
93 // Called when the download is being destroyed. This happens after 93 // Called when the download is being destroyed. This happens after
94 // every OnDownloadRemoved() as well as when the DownloadManager is going 94 // every OnDownloadRemoved() as well as when the DownloadManager is going
95 // down. 95 // down.
96 virtual void OnDownloadDestroyed(DownloadItem* download) {} 96 virtual void OnDownloadDestroyed(DownloadItem* download) {}
97 97
98 protected: 98 protected:
99 virtual ~Observer() {} 99 virtual ~Observer() {}
100 }; 100 };
101 101
102 virtual ~DownloadItem() {} 102 ~DownloadItem() override {}
103 103
104 // Observation --------------------------------------------------------------- 104 // Observation ---------------------------------------------------------------
105 105
106 virtual void AddObserver(DownloadItem::Observer* observer) = 0; 106 virtual void AddObserver(DownloadItem::Observer* observer) = 0;
107 virtual void RemoveObserver(DownloadItem::Observer* observer) = 0; 107 virtual void RemoveObserver(DownloadItem::Observer* observer) = 0;
108 virtual void UpdateObservers() = 0; 108 virtual void UpdateObservers() = 0;
109 109
110 // User Actions -------------------------------------------------------------- 110 // User Actions --------------------------------------------------------------
111 111
112 // Called when the user has validated the download of a dangerous file. 112 // Called when the user has validated the download of a dangerous file.
(...skipping 216 matching lines...) Expand 10 before | Expand all | Expand 10 after
329 // return |name|. Has no effect on the final target filename. 329 // return |name|. Has no effect on the final target filename.
330 virtual void SetDisplayName(const base::FilePath& name) = 0; 330 virtual void SetDisplayName(const base::FilePath& name) = 0;
331 331
332 // Debug/testing ------------------------------------------------------------- 332 // Debug/testing -------------------------------------------------------------
333 virtual std::string DebugString(bool verbose) const = 0; 333 virtual std::string DebugString(bool verbose) const = 0;
334 }; 334 };
335 335
336 } // namespace content 336 } // namespace content
337 337
338 #endif // CONTENT_PUBLIC_BROWSER_DOWNLOAD_ITEM_H_ 338 #endif // CONTENT_PUBLIC_BROWSER_DOWNLOAD_ITEM_H_
OLDNEW
« no previous file with comments | « content/public/browser/browser_message_filter.cc ('k') | content/public/browser/download_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698