Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Unified Diff: cc/trees/layer_tree_host_impl.h

Issue 671653005: SetNeedsRedraw directly when updating a visible tile. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: pinchblurmerge-test: comments Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/trees/layer_tree_host_impl.h
diff --git a/cc/trees/layer_tree_host_impl.h b/cc/trees/layer_tree_host_impl.h
index 511a56b110705bf561f087770096bbec6a8bc18b..528e71c5fd7cb1ba5b8233b4737d0fd9ca1788d9 100644
--- a/cc/trees/layer_tree_host_impl.h
+++ b/cc/trees/layer_tree_host_impl.h
@@ -83,7 +83,6 @@ class LayerTreeHostImplClient {
virtual void SetNeedsRedrawOnImplThread() = 0;
virtual void SetNeedsRedrawRectOnImplThread(const gfx::Rect& damage_rect) = 0;
virtual void SetNeedsAnimateOnImplThread() = 0;
- virtual void DidInitializeVisibleTileOnImplThread() = 0;
virtual void SetNeedsCommitOnImplThread() = 0;
virtual void SetNeedsManageTilesOnImplThread() = 0;
virtual void PostAnimationEventsToMainThreadOnImplThread(
@@ -175,7 +174,6 @@ class CC_EXPORT LayerTreeHostImpl
RenderPassIdHashMap render_passes_by_id;
const LayerImplList* render_surface_layer_list;
LayerImplList will_draw_layers;
- bool contains_incomplete_tile;
bool has_no_damage;
// RenderPassSink implementation.
@@ -214,9 +212,6 @@ class CC_EXPORT LayerTreeHostImpl
// immediately if any notifications had been blocked while blocking.
virtual void BlockNotifyReadyToActivateForTesting(bool block);
- // This allows us to inject DidInitializeVisibleTile events for testing.
- void DidInitializeVisibleTileForTesting();
-
// Resets all of the trees to an empty state.
void ResetTreesForTesting();
@@ -308,7 +303,6 @@ class CC_EXPORT LayerTreeHostImpl
return pending_tree_ ? pending_tree_.get() : active_tree_.get();
}
virtual void CreatePendingTree();
- virtual void UpdateVisibleTiles();
virtual void ActivateSyncTree();
// Shortcuts to layers on the active tree.
@@ -580,8 +574,6 @@ class CC_EXPORT LayerTreeHostImpl
bool zero_budget);
void EnforceManagedMemoryPolicy(const ManagedMemoryPolicy& policy);
- void DidInitializeVisibleTile();
-
void MarkUIResourceNotEvicted(UIResourceId uid);
void NotifySwapPromiseMonitorsOfSetNeedsRedraw();
@@ -704,8 +696,6 @@ class CC_EXPORT LayerTreeHostImpl
MicroBenchmarkControllerImpl micro_benchmark_controller_;
scoped_ptr<TaskGraphRunner> single_thread_synchronous_task_graph_runner_;
- bool need_to_update_visible_tiles_before_draw_;
-
// Optional callback to notify of new tree activations.
base::Closure tree_activation_callback_;
@@ -719,6 +709,7 @@ class CC_EXPORT LayerTreeHostImpl
std::vector<PictureLayerImpl::Pair> picture_layer_pairs_;
bool requires_high_res_to_draw_;
+ bool required_for_draw_tile_is_top_of_raster_queue_;
DISALLOW_COPY_AND_ASSIGN(LayerTreeHostImpl);
};

Powered by Google App Engine
This is Rietveld 408576698