Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1519)

Unified Diff: cc/resources/tile_manager.cc

Issue 671653005: SetNeedsRedraw directly when updating a visible tile. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/resources/tile_manager.cc
diff --git a/cc/resources/tile_manager.cc b/cc/resources/tile_manager.cc
index 77c4df607639fd51e57cb22c35d6c344d618e200..d510e1038147b418501e2749daaa0369f03370df 100644
--- a/cc/resources/tile_manager.cc
+++ b/cc/resources/tile_manager.cc
@@ -372,7 +372,9 @@ void TileManager::DidFinishRunningTasks(TaskSet task_set) {
}
mts.draw_info.set_rasterize_on_demand();
- client_->NotifyTileStateChanged(tile);
+ bool visible_tile =
+ tile->priority(ACTIVE_TREE).distance_to_visible == 0.f;
+ client_->NotifyTileStateChanged(tile, visible_tile);
}
raster_priority_queue_.Pop();
}
@@ -429,6 +431,7 @@ void TileManager::ManageTiles(const GlobalStateThatImpactsTilePriority& state) {
}
bool TileManager::UpdateVisibleTiles() {
+ return false;
TRACE_EVENT0("cc", "TileManager::UpdateVisibleTiles");
rasterizer_->CheckForCompletedTasks();
vmpstr 2014/10/28 01:35:34 We still need something to check for completed tas
enne (OOO) 2014/10/28 18:09:21 Yeah. If we're using async uploads, we need to ch
danakj 2014/10/31 20:02:01 Right, no longer changing this method.
@@ -656,8 +659,10 @@ void TileManager::FreeResourcesForTileAndNotifyClientIfTileWasReadyToDraw(
Tile* tile) {
bool was_ready_to_draw = tile->IsReadyToDraw();
FreeResourcesForTile(tile);
- if (was_ready_to_draw)
- client_->NotifyTileStateChanged(tile);
+ if (was_ready_to_draw) {
+ bool visible_tile = tile->priority(ACTIVE_TREE).distance_to_visible == 0.f;
+ client_->NotifyTileStateChanged(tile, visible_tile);
+ }
}
void TileManager::ScheduleTasks(
@@ -821,10 +826,13 @@ void TileManager::OnRasterTaskCompleted(
mts.draw_info.resource_ = resource.Pass();
}
- if (tile->priority(ACTIVE_TREE).distance_to_visible == 0.f)
+ bool visible_tile = false;
+ if (tile->priority(ACTIVE_TREE).distance_to_visible == 0.f) {
+ visible_tile = true;
did_initialize_visible_tile_ = true;
+ }
- client_->NotifyTileStateChanged(tile);
+ client_->NotifyTileStateChanged(tile, visible_tile);
}
scoped_refptr<Tile> TileManager::CreateTile(PicturePileImpl* picture_pile,

Powered by Google App Engine
This is Rietveld 408576698