SetNeedsRedraw directly when updating a visible tile.

cc/test/fake_picture_pile_impl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/test/fake_picture_pile_impl.h"
 
 #include <algorithm>
 #include <limits>
 #include <utility>
 
+#include "base/synchronization/waitable_event.h"
 #include "cc/resources/picture_pile.h"
 #include "cc/test/fake_picture_pile.h"
 #include "cc/test/impl_side_painting_settings.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace cc {
 
-FakePicturePileImpl::FakePicturePileImpl() {}
+FakePicturePileImpl::FakePicturePileImpl() : raster_thread_blocker_(nullptr) {
+}
 
-FakePicturePileImpl::FakePicturePileImpl(const PicturePile* other)
+FakePicturePileImpl::FakePicturePileImpl(const PicturePile* other,
+                                         base::WaitableEvent* blocker)
     : PicturePileImpl(other),
+      raster_thread_blocker_(blocker),
       tile_grid_info_(other->GetTileGridInfoForTesting()) {
 }
 
 FakePicturePileImpl::~FakePicturePileImpl() {}
 
 scoped_refptr<FakePicturePileImpl> FakePicturePileImpl::CreateFilledPile(
     const gfx::Size& tile_size,
     const gfx::Size& layer_bounds) {
   FakePicturePile pile;
   pile.tiling().SetTilingSize(layer_bounds);
   pile.tiling().SetMaxTextureSize(tile_size);
   pile.SetTileGridSize(ImplSidePaintingSettings().default_tile_grid_size);
   pile.SetRecordedViewport(gfx::Rect(layer_bounds));
   pile.SetHasAnyRecordings(true);
 
-  auto pile_impl = make_scoped_refptr(new FakePicturePileImpl(&pile));
+  auto pile_impl = make_scoped_refptr(new FakePicturePileImpl(&pile, nullptr));
   for (int x = 0; x < pile_impl->tiling().num_tiles_x(); ++x) {
     for (int y = 0; y < pile_impl->tiling().num_tiles_y(); ++y)
       pile_impl->AddRecordingAt(x, y);
   }
   return pile_impl;
 }
 
 scoped_refptr<FakePicturePileImpl> FakePicturePileImpl::CreateEmptyPile(
     const gfx::Size& tile_size,
     const gfx::Size& layer_bounds) {
   FakePicturePile pile;
   pile.tiling().SetTilingSize(layer_bounds);
   pile.tiling().SetMaxTextureSize(tile_size);
   pile.SetTileGridSize(ImplSidePaintingSettings().default_tile_grid_size);
   pile.SetRecordedViewport(gfx::Rect());
   pile.SetHasAnyRecordings(false);
-  return make_scoped_refptr(new FakePicturePileImpl(&pile));
+  return make_scoped_refptr(new FakePicturePileImpl(&pile, nullptr));
 }
 
 scoped_refptr<FakePicturePileImpl>
 FakePicturePileImpl::CreateEmptyPileThatThinksItHasRecordings(
     const gfx::Size& tile_size,
     const gfx::Size& layer_bounds) {
   FakePicturePile pile;
   pile.tiling().SetTilingSize(layer_bounds);
   pile.tiling().SetMaxTextureSize(tile_size);
   pile.SetTileGridSize(ImplSidePaintingSettings().default_tile_grid_size);
   // This simulates a false positive for this flag.
   pile.SetRecordedViewport(gfx::Rect());
   pile.SetHasAnyRecordings(true);
-  return make_scoped_refptr(new FakePicturePileImpl(&pile));
+  return make_scoped_refptr(new FakePicturePileImpl(&pile, nullptr));
 }
 
 scoped_refptr<FakePicturePileImpl>
 FakePicturePileImpl::CreateInfiniteFilledPile() {
   FakePicturePile pile;
   gfx::Size size(std::numeric_limits<int>::max(),
                  std::numeric_limits<int>::max());
   pile.tiling().SetTilingSize(size);
   pile.tiling().SetMaxTextureSize(size);
   pile.SetTileGridSize(size);
   pile.SetRecordedViewport(gfx::Rect(size));
   pile.SetHasAnyRecordings(true);
 
-  auto pile_impl = make_scoped_refptr(new FakePicturePileImpl(&pile));
+  auto pile_impl = make_scoped_refptr(new FakePicturePileImpl(&pile, nullptr));
   pile_impl->AddRecordingAt(0, 0);
   return pile_impl;
 }
 
+scoped_refptr<FakePicturePileImpl> FakePicturePileImpl::CreateFromPile(
+    const PicturePile* other,
+    base::WaitableEvent* blocker) {
+  return make_scoped_refptr(new FakePicturePileImpl(other, blocker));
+}
+
+void FakePicturePileImpl::PlaybackToCanvas(SkCanvas* canvas,
+                                           const gfx::Rect& canvas_rect,
+                                           float contents_scale) const {
+  PicturePileImpl::PlaybackToCanvas(canvas, canvas_rect, contents_scale);

[reveman, 2014/11/13 20:50:58]

Move the Wait() call above this line if you use my |playback_allowed_event_|
name suggestion. I'm assuming this doesn't matter for your use-case. Not sure
what to name it if keep the Wait() call below instead.
|allow_playback_to_finish_event_| maybe..

[danakj, 2014/11/13 21:24:40]

Right it doesn't matter, it's just blocking this function returning. Done.

+  if (raster_thread_blocker_)
+    raster_thread_blocker_->Wait();
+}
+
 void FakePicturePileImpl::AddRecordingAt(int x, int y) {
   EXPECT_GE(x, 0);
   EXPECT_GE(y, 0);
   EXPECT_LT(x, tiling_.num_tiles_x());
   EXPECT_LT(y, tiling_.num_tiles_y());
 
   if (HasRecordingAt(x, y))
     return;
   gfx::Rect bounds(tiling().TileBounds(x, y));
   bounds.Inset(-buffer_pixels(), -buffer_pixels());
@@ skipping 61 matching lines @@
   Clear();
   tiling_.SetBorderTexels(new_buffer_pixels);
 }
 
 void FakePicturePileImpl::Clear() {
   picture_map_.clear();
   recorded_viewport_ = gfx::Rect();
 }
 
 }  // namespace cc