SetNeedsRedraw directly when updating a visible tile.

cc/test/fake_picture_pile.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CC_TEST_FAKE_PICTURE_PILE_H_
 #define CC_TEST_FAKE_PICTURE_PILE_H_
 
 #include "cc/resources/picture_pile.h"
 
+namespace base {
+class WaitableEvent;
+}
+
 namespace cc {
 
 class FakePicturePile : public PicturePile {
  public:
+  FakePicturePile() : raster_thread_blocker_(nullptr) {}
   ~FakePicturePile() override {}
 
+  // PicturePile overrides.
+  scoped_refptr<RasterSource> CreateRasterSource() const override;
+
   using PicturePile::buffer_pixels;
   using PicturePile::CanRasterSlowTileCheck;
   using PicturePile::Clear;
 
   PictureMap& picture_map() { return picture_map_; }
   const gfx::Rect& recorded_viewport() const { return recorded_viewport_; }
 
   bool CanRasterLayerRect(gfx::Rect layer_rect) {
     layer_rect.Intersect(gfx::Rect(tiling_.tiling_size()));
     if (recorded_viewport_.Contains(layer_rect))
       return true;
     return CanRasterSlowTileCheck(layer_rect);
   }
 
   bool HasRecordings() const { return has_any_recordings_; }
 
   void SetRecordedViewport(const gfx::Rect& viewport) {
     recorded_viewport_ = viewport;
   }
 
   void SetHasAnyRecordings(bool has_recordings) {
     has_any_recordings_ = has_recordings;
   }
 
+  void SetRasterThreadBlocker(base::WaitableEvent* blocker) {
+    raster_thread_blocker_ = blocker;
+  }
+
   TilingData& tiling() { return tiling_; }
 
   bool is_solid_color() const { return is_solid_color_; }
   SkColor solid_color() const { return solid_color_; }
 
   void SetPixelRecordDistance(int d) { pixel_record_distance_ = d; }
 
   typedef PicturePile::PictureInfo PictureInfo;
   typedef PicturePile::PictureMapKey PictureMapKey;
   typedef PicturePile::PictureMap PictureMap;
+
+ private:
+  base::WaitableEvent* raster_thread_blocker_;

[reveman, 2014/11/13 20:50:58]

I don't think this code should be aware of raster threads or make the assumption
that playback might happen on a raster thread. Can you rename this and related
code to something like "playback_allowed_event_?

[danakj, 2014/11/13 21:24:40]

Hm, heh. I named it this thinking "it blocks the thread that does raster", which
is what it's doing, not so much about the concept of "raster threads". And the
playback /has/ to happen on a different thread or this test would deadlock when
it called Wait(). This is test code, is it really that important? I'll just
rename this to unblock me, but I don't see the point of this change I guess.

 };
+
 }  // namespace cc
 
 #endif  // CC_TEST_FAKE_PICTURE_PILE_H_