Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 671633003: Roll android_tools and breakpad to the latest. (Closed)

Created:
6 years, 2 months ago by Fabrice (no longer in Chrome)
Modified:
6 years, 2 months ago
CC:
chromium-reviews, klundberg+watch_chromium.org, erikwright+watch_chromium.org, yfriedman+watch_chromium.org, Torne
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Roll android_tools and breakpad to the latest. This picks up in android_tools: Updated SDK build tools to 21.0.1 and removed old versions. Upgrade NDK to r10c. And in breakpad: Update breakpad to support Android NDK r10c Fixing the Mac Inspector build by adding the launch_report dependency to the breakpadUtilities dylib project after it got pulled out from Inspector.mm. Refactor .so name detection logic in minidump/linux_dumper. The process uptime computation when the Windows out-of-process Crash Generation Server is used is done by subtracting the crashing process creation time from the current time when the crash is generated. Linux multiprocess crash reporter: use pipe instead of socketpair in the client. Remove workaround for Linux credential-passing bug. TBR=brettw, danakj NOTRY=true BUG=424680, 425077, 358831 Committed: https://crrev.com/79bd5f12620f81dd241984d925b87a888e1dc37b Cr-Commit-Position: refs/heads/master@{#300671}

Patch Set 1 #

Patch Set 2 : Add landmine #

Patch Set 3 : x86 fix in breakpad + script update for recipe bots #

Patch Set 4 : why do you people add useless arguments and define things twice? #

Total comments: 2

Patch Set 5 : Review comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -20 lines) Patch
M DEPS View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M base/sys_info_android.cc View 1 chunk +1 line, -2 lines 0 comments Download
M build/android/pylib/constants.py View 1 chunk +1 line, -1 line 0 comments Download
M build/common.gypi View 4 chunks +4 lines, -4 lines 0 comments Download
M build/config/android/config.gni View 1 chunk +1 line, -1 line 0 comments Download
M build/get_landmines.py View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/android_platform/README.chromium View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/android_platform/development/scripts/symbol.py View 1 2 3 4 3 chunks +8 lines, -10 lines 0 comments Download

Messages

Total messages: 26 (9 generated)
Fabrice (no longer in Chrome)
6 years, 2 months ago (2014-10-21 08:38:30 UTC) #2
rmcilroy
On 2014/10/21 08:38:30, Fabrice de Gans wrote: Looks fine, but the bots don't seem to ...
6 years, 2 months ago (2014-10-21 09:53:35 UTC) #3
Fabrice (no longer in Chrome)
6 years, 2 months ago (2014-10-21 13:57:21 UTC) #5
Finnur
Yeah, I lost a couple of hours to this as well while working in my ...
6 years, 2 months ago (2014-10-21 14:29:51 UTC) #6
Finnur
Ooops, wrong CL. I mistook rmcilroy's reference to "bots" as "build bots", not "try bots". ...
6 years, 2 months ago (2014-10-21 14:45:56 UTC) #7
Fabrice (no longer in Chrome)
And we have green bots (patch set 3)! The failing tests seem to be flaky, ...
6 years, 2 months ago (2014-10-21 15:39:39 UTC) #8
rmcilroy
lgtm once comment is addressed. https://codereview.chromium.org/671633003/diff/60001/third_party/android_platform/development/scripts/symbol.py File third_party/android_platform/development/scripts/symbol.py (right): https://codereview.chromium.org/671633003/diff/60001/third_party/android_platform/development/scripts/symbol.py#newcode65 third_party/android_platform/development/scripts/symbol.py:65: toolchain_prefix = "i686-android-linux" i686-linux-android ...
6 years, 2 months ago (2014-10-21 17:40:29 UTC) #9
rmcilroy
Ccing Torne who needs this change for WebView.
6 years, 2 months ago (2014-10-22 09:44:38 UTC) #10
Fabrice (no longer in Chrome)
Thanks, I missed that one. I'm not sure why we duplicate these strings and have ...
6 years, 2 months ago (2014-10-22 10:46:31 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/671633003/80001
6 years, 2 months ago (2014-10-22 10:48:50 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/671633003/80001
6 years, 2 months ago (2014-10-22 12:55:38 UTC) #18
Fabrice (no longer in Chrome)
Every trybot is green except for one that is permanently stuck. NOTRY'ing it :/
6 years, 2 months ago (2014-10-22 12:57:06 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/671633003/80001
6 years, 2 months ago (2014-10-22 12:57:34 UTC) #22
commit-bot: I haz the power
Committed patchset #5 (id:80001)
6 years, 2 months ago (2014-10-22 12:58:31 UTC) #23
commit-bot: I haz the power
Patchset 5 (id:??) landed as https://crrev.com/79bd5f12620f81dd241984d925b87a888e1dc37b Cr-Commit-Position: refs/heads/master@{#300671}
6 years, 2 months ago (2014-10-22 12:59:19 UTC) #24
ppi
A revert of this CL (patchset #5 id:80001) has been created in https://codereview.chromium.org/676453002/ by ppi@chromium.org. ...
6 years, 2 months ago (2014-10-22 16:36:58 UTC) #25
danakj
6 years, 2 months ago (2014-10-22 17:51:06 UTC) #26
Message was sent while issue was closed.
base LGTM

Powered by Google App Engine
This is Rietveld 408576698