Issue 671613003: Eliminate FontBuilder::initForStyleResolve.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 671613003: Eliminate FontBuilder::initForStyleResolve. (Closed)

Created:
6 years, 2 months ago by andersr

Modified:
6 years, 2 months ago

Reviewers:
dglazkov

CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-dom_chromium.org, dglazkov+blink, eae+blinkwatch, ed+blinkwatch_opera.com, rwlbuis, rune+blink, sof

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

Eliminate FontBuilder::initForStyleResolve. It's not necessary to do initialization of FontBuilder separately from StyleResolverState::setStyle. It just adds noise. Also, use a reference for Document in FontBuilder, since its existence can be guaranteed in all cases. R=dglazkov@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184342

Patch Set 1 #

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+27 lines, -40 lines)			Patch
M	Source/core/css/resolver/FontBuilder.h	View	2 chunks	+3 lines, -5 lines	0 comments	Download
M	Source/core/css/resolver/FontBuilder.cpp	View	6 chunks	+12 lines, -20 lines	0 comments	Download
M	Source/core/css/resolver/FontBuilderTest.cpp	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	Source/core/css/resolver/StyleResolver.cpp	View	7 chunks	+0 lines, -11 lines	0 comments	Download
M	Source/core/css/resolver/StyleResolverState.h	View	1 chunk	+6 lines, -1 line	0 comments	Download
M	Source/core/css/resolver/StyleResolverState.cpp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/dom/Document.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/671613003/1

6 years, 2 months ago (2014-10-24 08:21:45 UTC) #5

commit-bot: I haz the power

6 years, 2 months ago (2014-10-24 09:48:52 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as 184342

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages