Identifying call sites that need to handle out of memory situations in Courgette.

courgette/encoded_program_unittest.cc

Index: courgette/encoded_program_unittest.cc
===================================================================
--- courgette/encoded_program_unittest.cc	(revision 78901)
+++ courgette/encoded_program_unittest.cc	(working copy)
@@ -17,18 +17,18 @@
   uint32 base = 0x00900000;
   program->set_image_base(base);
 
-  program->DefineRel32Label(5, 0);  // REL32 index 5 == base + 0
-  program->DefineAbs32Label(7, 4);  // ABS32 index 7 == base + 4
+  EXPECT_TRUE(program->DefineRel32Label(5, 0));  // REL32 index 5 == base + 0

[amit, 2011/03/22 17:43:36]

nit: will be nice to have some negative tests?

[tommi (sloooow) - chröme, 2011/03/22 18:37:49]

Yes, I'm going to add something along those lines in the next cl.

+  EXPECT_TRUE(program->DefineAbs32Label(7, 4));  // ABS32 index 7 == base + 4
   program->EndLabels();
 
-  program->AddOrigin(0);  // Start at base.
-  program->AddAbs32(7);
-  program->AddRel32(5);
+  EXPECT_TRUE(program->AddOrigin(0));  // Start at base.
+  EXPECT_TRUE(program->AddAbs32(7));
+  EXPECT_TRUE(program->AddRel32(5));
 
   // Serialize and deserialize.
 
   courgette::SinkStreamSet sinks;
-  program->WriteTo(&sinks);
+  EXPECT_TRUE(program->WriteTo(&sinks));
 
   courgette::SinkStream sink;
   bool can_collect = sinks.CopyTo(&sink);