Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Side by Side Diff: components/omnibox/omnibox_field_trial.h

Issue 671593002: Do not delay most visited results. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_OMNIBOX_OMNIBOX_FIELD_TRIAL_H_ 5 #ifndef COMPONENTS_OMNIBOX_OMNIBOX_FIELD_TRIAL_H_
6 #define COMPONENTS_OMNIBOX_OMNIBOX_FIELD_TRIAL_H_ 6 #define COMPONENTS_OMNIBOX_OMNIBOX_FIELD_TRIAL_H_
7 7
8 #include <map> 8 #include <map>
9 #include <string> 9 #include <string>
10 #include <vector> 10 #include <vector>
(...skipping 117 matching lines...) Expand 10 before | Expand all | Expand 10 after
128 static base::TimeDelta StopTimerFieldTrialDuration(); 128 static base::TimeDelta StopTimerFieldTrialDuration();
129 129
130 // --------------------------------------------------------- 130 // ---------------------------------------------------------
131 // For the ZeroSuggestProvider field trial. 131 // For the ZeroSuggestProvider field trial.
132 132
133 // Returns whether the user is in any field trial where the 133 // Returns whether the user is in any field trial where the
134 // ZeroSuggestProvider should be used to get suggestions when the 134 // ZeroSuggestProvider should be used to get suggestions when the
135 // user clicks on the omnibox but has not typed anything yet. 135 // user clicks on the omnibox but has not typed anything yet.
136 static bool InZeroSuggestFieldTrial(); 136 static bool InZeroSuggestFieldTrial();
137 137
138 // Returns whether the user is in a ZeroSuggest field trial, but should 138 // Returns whether the user is in a ZeroSuggest field trial, which shows
139 // show most visited URL instead. This is used to compare metrics of 139 // most visited URLs. This is true for both "MostVisited" and
140 // ZeroSuggest and most visited suggestions. 140 // "MostVisitedWithoutSERP" trials.
141 static bool InZeroSuggestMostVisitedFieldTrial(); 141 static bool InZeroSuggestMostVisitedFieldTrial();
142 142
143 // Returns whether the user is in ZeroSuggest field trial showing most
144 // visited URLs. This is slightly different from the trial above in that
Mark P 2014/10/21 19:08:06 nit: ". This is slightly different from the trial
Maria 2014/10/21 23:57:39 Done.
145 // it doesn't show suggestions on Google search result pages.
146 static bool InZeroSuggestMostVisitedWithoutSerpFieldTrial();
147
143 // Returns whether the user is in a ZeroSuggest field trial and URL-based 148 // Returns whether the user is in a ZeroSuggest field trial and URL-based
144 // suggestions can continue to appear after the user has started typing. 149 // suggestions can continue to appear after the user has started typing.
145 static bool InZeroSuggestAfterTypingFieldTrial(); 150 static bool InZeroSuggestAfterTypingFieldTrial();
146 151
147 // Returns whether the user is in a ZeroSuggest field trial, but should 152 // Returns whether the user is in a ZeroSuggest field trial, but should
148 // show recently searched-for queries instead. 153 // show recently searched-for queries instead.
149 static bool InZeroSuggestPersonalizedFieldTrial(); 154 static bool InZeroSuggestPersonalizedFieldTrial();
150 155
151 // --------------------------------------------------------- 156 // ---------------------------------------------------------
152 // For the ShortcutsScoringMaxRelevance experiment that's part of the 157 // For the ShortcutsScoringMaxRelevance experiment that's part of the
(...skipping 173 matching lines...) Expand 10 before | Expand all | Expand 10 after
326 // prioritize different wildcard contexts, see the implementation. How to 331 // prioritize different wildcard contexts, see the implementation. How to
327 // interpret the value is left to the caller; this is rule-dependent. 332 // interpret the value is left to the caller; this is rule-dependent.
328 static std::string GetValueForRuleInContext( 333 static std::string GetValueForRuleInContext(
329 const std::string& rule, 334 const std::string& rule,
330 metrics::OmniboxEventProto::PageClassification page_classification); 335 metrics::OmniboxEventProto::PageClassification page_classification);
331 336
332 DISALLOW_IMPLICIT_CONSTRUCTORS(OmniboxFieldTrial); 337 DISALLOW_IMPLICIT_CONSTRUCTORS(OmniboxFieldTrial);
333 }; 338 };
334 339
335 #endif // COMPONENTS_OMNIBOX_OMNIBOX_FIELD_TRIAL_H_ 340 #endif // COMPONENTS_OMNIBOX_OMNIBOX_FIELD_TRIAL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698