LayoutTests/http/tests/serviceworker/resources/appcache-ordering.install.html - Issue 671583002: Test: Pages controlled by ServiceWorkers should not participate in AppCaching

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/http/tests/serviceworker/resources/appcache-ordering.install.html

Issue 671583002: Test: Pages controlled by ServiceWorkers should not participate in AppCaching (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« LayoutTests/http/tests/serviceworker/appcache-ordering-main.html ('K') | « LayoutTests/http/tests/serviceworker/resources/appcache-ordering.manifest ('k') | LayoutTests/http/tests/serviceworker/resources/appcache-ordering.is-appcached.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <html manifest="appcache-ordering.manifest">

	2 <script>

	3 var handled = false;

	4

	5 function installComplete()
	falken 2014/10/21 01:28:31 snake_case for consistency snake_case for consistency
	6 {

	7 if (handled)

	8 return;

	9 handled = true;

	10 window.parent.notifyAppCacheInstalled(true);

	11 }

	12

	13 function installFailed()

	14 {

	15 if (handled)

	16 return;

	17 handled = true;

	18 window.parent.notifyAppCacheInstalled(false);

	19 }

	20

	21 applicationCache.oncached = installComplete;

	22 applicationCache.onnoupdate = installComplete;

	23 applicationCache.onupdateready = installFailed;

	24 applicationCache.onerror = installFailed;

	25 applicationCache.onobsolete =installFailed;
	falken 2014/10/21 01:28:31 nit: missing space after = nit: missing space after =
	26

	27 </script>

	28 </html>

OLD	NEW