Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(522)

Issue 671553002: Move extensions manifest handler for OAuth2 to //extensions (Closed)

Created:
6 years, 2 months ago by James Cook
Modified:
6 years, 2 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Move extensions manifest handler for OAuth2 to //extensions app_shell needs the client ID and oauth2 scopes for its identity API. Just a refactor, no functional changes. BUG=424653 TEST=extensions_unittests TBR=xiyuan@chromium.org for header file rename touching chrome/browser/signin/easy_unlock_toggle_flow.cc Committed: https://crrev.com/71187e343e2a8005dff92649b3013ba5019f974a Cr-Commit-Position: refs/heads/master@{#300380}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -520 lines) Patch
M chrome/browser/extensions/api/identity/gaia_web_auth_flow.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/identity/identity_api.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/identity/identity_apitest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/signin/easy_unlock_toggle_flow.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_common.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/extensions/api/_manifest_features.json View 3 chunks +0 lines, -34 lines 0 comments Download
D chrome/common/extensions/api/identity/extension_manifests_auth_unittest.cc View 1 chunk +0 lines, -322 lines 0 comments Download
D chrome/common/extensions/api/identity/oauth2_manifest_handler.h View 1 chunk +0 lines, -48 lines 0 comments Download
D chrome/common/extensions/api/identity/oauth2_manifest_handler.cc View 1 chunk +0 lines, -98 lines 0 comments Download
M chrome/common/extensions/chrome_manifest_handlers.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M extensions/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/common/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M extensions/common/api/_manifest_features.json View 3 chunks +34 lines, -0 lines 0 comments Download
M extensions/common/common_manifest_handlers.cc View 2 chunks +2 lines, -0 lines 0 comments Download
A + extensions/common/manifest_handlers/oauth2_manifest_handler.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + extensions/common/manifest_handlers/oauth2_manifest_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
A + extensions/common/manifest_handlers/oauth2_manifest_unittest.cc View 4 chunks +3 lines, -5 lines 0 comments Download
M extensions/extensions.gyp View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
James Cook
rockot, PTAL
6 years, 2 months ago (2014-10-20 21:47:18 UTC) #2
Ken Rockot(use gerrit already)
lgtm
6 years, 2 months ago (2014-10-20 22:55:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/671553002/1
6 years, 2 months ago (2014-10-20 23:04:33 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-20 23:47:30 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-20 23:48:13 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/71187e343e2a8005dff92649b3013ba5019f974a
Cr-Commit-Position: refs/heads/master@{#300380}

Powered by Google App Engine
This is Rietveld 408576698