Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(625)

Issue 671533005: Use disabled-by-default prefix in logging NetLog events to TraceLog (Closed)

Created:
6 years, 2 months ago by xunjieli
Modified:
6 years, 2 months ago
Reviewers:
nduca, mmenke
CC:
nduca, cbentzel+watch_chromium.org, chromium-reviews, dsinclair
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Use disabled-by-default prefix in logging NetLog events to TraceLog BUG=399701 Committed: https://crrev.com/1d2e6f597e27f549dd27227396d0838b9228d85f Cr-Commit-Position: refs/heads/master@{#300543}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Used macro #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -15 lines) Patch
M net/base/trace_net_log_observer.cc View 1 2 chunks +9 lines, -3 lines 0 comments Download
M net/base/trace_net_log_observer_unittest.cc View 1 11 chunks +16 lines, -12 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
xunjieli
Hi Matt,I forgot we should prefix "netlog" category with a "disabled-by-default" prefix. As nduca@ mentioned ...
6 years, 2 months ago (2014-10-21 17:40:20 UTC) #2
nduca
some nits, lgtm when resolved https://codereview.chromium.org/671533005/diff/1/net/base/trace_net_log_observer_unittest.cc File net/base/trace_net_log_observer_unittest.cc (right): https://codereview.chromium.org/671533005/diff/1/net/base/trace_net_log_observer_unittest.cc#newcode31 net/base/trace_net_log_observer_unittest.cc:31: const char kNetLogTracingCategory[] = ...
6 years, 2 months ago (2014-10-21 17:50:08 UTC) #4
xunjieli
https://codereview.chromium.org/671533005/diff/1/net/base/trace_net_log_observer_unittest.cc File net/base/trace_net_log_observer_unittest.cc (right): https://codereview.chromium.org/671533005/diff/1/net/base/trace_net_log_observer_unittest.cc#newcode31 net/base/trace_net_log_observer_unittest.cc:31: const char kNetLogTracingCategory[] = "disabled-by-default-netlog"; On 2014/10/21 17:50:07, nduca ...
6 years, 2 months ago (2014-10-21 17:55:15 UTC) #5
mmenke
LGTM
6 years, 2 months ago (2014-10-21 18:36:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/671533005/20001
6 years, 2 months ago (2014-10-21 18:37:55 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 2 months ago (2014-10-21 20:05:08 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-10-21 20:06:24 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1d2e6f597e27f549dd27227396d0838b9228d85f
Cr-Commit-Position: refs/heads/master@{#300543}

Powered by Google App Engine
This is Rietveld 408576698