Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 671533003: Add a flag to enable impl-thread event handling on Mac (Closed)

Created:
6 years, 2 months ago by ccameron
Modified:
6 years, 2 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add a flag to enable impl-thread event handling on Mac This feature is in active development. BUG=224781 Committed: https://crrev.com/1f89c007ba4f55f8b386a49d9824029e6bca963b Cr-Commit-Position: refs/heads/master@{#300427}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Incorporate review feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -10 lines) Patch
M content/browser/renderer_host/render_process_host_impl.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M content/public/common/content_switches.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/content_switches.cc View 1 1 chunk +6 lines, -1 line 0 comments Download
M content/renderer/render_view_impl.cc View 1 1 chunk +16 lines, -9 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
ccameron
Small patch to help with development.
6 years, 2 months ago (2014-10-20 23:53:28 UTC) #2
Avi (use Gerrit)
https://codereview.chromium.org/671533003/diff/1/content/public/common/content_switches.cc File content/public/common/content_switches.cc (right): https://codereview.chromium.org/671533003/diff/1/content/public/common/content_switches.cc#newcode947 content/public/common/content_switches.cc:947: Ditto. https://codereview.chromium.org/671533003/diff/1/content/public/common/content_switches.h File content/public/common/content_switches.h (right): https://codereview.chromium.org/671533003/diff/1/content/public/common/content_switches.h#newcode279 content/public/common/content_switches.h:279: #endif Why ...
6 years, 2 months ago (2014-10-21 00:03:53 UTC) #3
ccameron
https://codereview.chromium.org/671533003/diff/1/content/public/common/content_switches.cc File content/public/common/content_switches.cc (right): https://codereview.chromium.org/671533003/diff/1/content/public/common/content_switches.cc#newcode947 content/public/common/content_switches.cc:947: On 2014/10/21 00:03:53, Avi wrote: > Ditto. Done. https://codereview.chromium.org/671533003/diff/1/content/public/common/content_switches.h ...
6 years, 2 months ago (2014-10-21 00:14:46 UTC) #4
Avi (use Gerrit)
lgtm
6 years, 2 months ago (2014-10-21 03:35:44 UTC) #5
ccameron
Thanks!
6 years, 2 months ago (2014-10-21 05:23:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/671533003/20001
6 years, 2 months ago (2014-10-21 05:24:11 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 2 months ago (2014-10-21 06:19:19 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-10-21 06:19:58 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/1f89c007ba4f55f8b386a49d9824029e6bca963b
Cr-Commit-Position: refs/heads/master@{#300427}

Powered by Google App Engine
This is Rietveld 408576698