Issue 671513014: Make get_compile_targets.py work on Windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 671513014: Make get_compile_targets.py work on Windows (Closed)

Created:
6 years, 2 months ago by Paweł Hajdan Jr.

Modified:
6 years, 2 months ago

Reviewers:
bartfab (slow)

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Make get_compile_targets.py work on Windows BUG=422235 R=bartfab@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/9f8fcc9bf8f8a47ce9178f2d8b4a9459f7063b1d

Patch Set 1 #

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	testing/scripts/get_compile_targets.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

Patchset 1 (id:??) landed as https://crrev.com/9f8fcc9bf8f8a47ce9178f2d8b4a9459f7063b1d Cr-Commit-Position: refs/heads/master@{#300668}

6 years, 2 months ago (2014-10-22 12:33:17 UTC) #3

Paweł Hajdan Jr.

Committed patchset #1 (id:1) manually as 9f8fcc9bf8f8a47ce9178f2d8b4a9459f7063b1d.

6 years, 2 months ago (2014-10-22 12:33:50 UTC) #4

jam

6 years, 2 months ago (2014-10-22 16:28:49 UTC) #5

Message was sent while issue was closed.

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/676443002/ by jam@chromium.org.

The reason for reverting is: windows trybots broken

please be around after landing changes and verify that bots are working.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages