Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 671513011: Add a guard in MojoBootstrap::OnClientLaunched() (Closed)

Created:
6 years, 2 months ago by Hajime Morrita
Modified:
6 years, 2 months ago
Reviewers:
viettrungluu
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add a guard in MojoBootstrap::OnClientLaunched() There is a race where the IO thread got error after the UI thread launched a process. This CL rejects such a case. This is OK as the error is eventually notified to the UI thread. TEST=chromeos browser_tests with ChannelMojo being on. R=viettrungluu@chromium.org BUG=377980 Committed: https://crrev.com/0076bcf1a307e61d32dba4d94e2efa3f2643e3d4 Cr-Commit-Position: refs/heads/master@{#300589}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M ipc/mojo/ipc_mojo_bootstrap.h View 1 chunk +1 line, -0 lines 0 comments Download
M ipc/mojo/ipc_mojo_bootstrap.cc View 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Hajime Morrita
6 years, 2 months ago (2014-10-21 22:09:07 UTC) #1
Hajime Morrita
Trung: PTAL? I'm sweeping out remaining errors I'm seeing on https://codereview.chromium.org/664413003/
6 years, 2 months ago (2014-10-21 22:10:06 UTC) #2
viettrungluu
lgtm
6 years, 2 months ago (2014-10-21 22:17:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/671513011/1
6 years, 2 months ago (2014-10-21 22:41:43 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-22 00:59:35 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-22 04:04:25 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0076bcf1a307e61d32dba4d94e2efa3f2643e3d4
Cr-Commit-Position: refs/heads/master@{#300589}

Powered by Google App Engine
This is Rietveld 408576698