Issue 671513005: Standardize usage of virtual/override/final in chrome/browser/drive/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 671513005: Standardize usage of virtual/override/final in chrome/browser/drive/ (Closed)

Created:
6 years, 2 months ago by dcheng

Modified:
6 years, 2 months ago

Reviewers:
hashimoto

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Standardize usage of virtual/override/final in chrome/browser/drive/ This patch was automatically generated by applying clang fixit hints generated by the plugin to the source tree. BUG=417463 TBR=hashimoto@chromium.org Committed: https://crrev.com/a8d07741d90327f9953b3ebb02d195fb47010873 Cr-Commit-Position: refs/heads/master@{#300458}

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+140 lines, -145 lines)			Patch
M	chrome/browser/drive/drive_api_service.h	View	3 chunks	+38 lines, -38 lines	0 comments	Download
M	chrome/browser/drive/drive_app_registry_unittest.cc	View	1 chunk	+2 lines, -4 lines	0 comments	Download
M	chrome/browser/drive/drive_notification_manager.h	View	1 chunk	+5 lines, -6 lines	0 comments	Download
M	chrome/browser/drive/drive_notification_manager_factory.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/drive/drive_uploader.h	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/drive/drive_uploader_unittest.cc	View	11 chunks	+15 lines, -17 lines	0 comments	Download
M	chrome/browser/drive/dummy_drive_service.h	View	2 chunks	+37 lines, -37 lines	0 comments	Download
M	chrome/browser/drive/fake_drive_service.h	View	3 chunks	+37 lines, -37 lines	0 comments	Download

Total messages: 5 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/671513005/1

6 years, 2 months ago (2014-10-21 10:14:17 UTC) #3

commit-bot: I haz the power

6 years, 2 months ago (2014-10-21 11:28:56 UTC) #5

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/a8d07741d90327f9953b3ebb02d195fb47010873
Cr-Commit-Position: refs/heads/master@{#300458}