Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 671503006: Move GYP file lists into variables. (Closed)

Created:
6 years, 2 months ago by brettw
Modified:
6 years, 2 months ago
Reviewers:
brucedawson
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Move GYP file lists into variables. Moves most of the large file lists in chrome_tests to variables defined at the top of the file. This will allow the lists to be shared with the GN build. R=brucedawson@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/51530f07a1d3c34248944156556d7280c9b049e5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+510 lines, -480 lines) Patch
M chrome/chrome_tests.gypi View 11 chunks +510 lines, -480 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
brettw
Hi Bruce, since you said you were looking at GN, here's a simple patch to ...
6 years, 2 months ago (2014-10-21 18:05:35 UTC) #2
brucedawson
lgtm
6 years, 2 months ago (2014-10-22 17:44:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/671503006/1
6 years, 2 months ago (2014-10-22 17:49:36 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 2 months ago (2014-10-22 17:49:39 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/51530f07a1d3c34248944156556d7280c9b049e5 Cr-Commit-Position: refs/heads/master@{#300702}
6 years, 2 months ago (2014-10-22 17:58:49 UTC) #8
brettw
6 years, 2 months ago (2014-10-22 17:59:00 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
51530f07a1d3c34248944156556d7280c9b049e5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698