content/renderer/render_view_impl.h - Issue 671503005: Plumb composition character bounds for Android 5.0

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_view_impl.h

Issue 671503005: Plumb composition character bounds for Android 5.0 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/render_view_impl.h

diff --git a/content/renderer/render_view_impl.h b/content/renderer/render_view_impl.h

index ec6d730553f59d3f830abeb6a4b961c412153954..e2b14001c69a8f5f275468c8142e68274a0c98c4 100644

--- a/content/renderer/render_view_impl.h

+++ b/content/renderer/render_view_impl.h

@@ -527,7 +527,7 @@ class CONTENT_EXPORT RenderViewImpl

virtual void OnOrientationChange() override;

virtual ui::TextInputType GetTextInputType() override;

virtual void GetSelectionBounds(gfx::Rect* start, gfx::Rect* end) override;

-#if defined(OS_MACOSX) || defined(USE_AURA)

+#if defined(OS_MACOSX) || defined(USE_AURA) || defined(OS_ANDROID)

virtual void GetCompositionCharacterBounds(

std::vector<gfx::Rect>* character_bounds) override;

virtual void GetCompositionRange(gfx::Range* range) override;