Plumb composition character bounds for Android 5.0

content/browser/renderer_host/render_widget_host_view_android.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/render_widget_host_view_android.h"
 
 #include <android/bitmap.h>
 
 #include "base/android/build_info.h"
 #include "base/basictypes.h"
@@ skipping 742 matching lines @@
 
 void RenderWidgetHostViewAndroid::SetMultiTouchZoomSupportEnabled(
     bool enabled) {
   gesture_provider_.SetMultiTouchZoomSupportEnabled(enabled);
 }
 
 void RenderWidgetHostViewAndroid::ImeCancelComposition() {
   ime_adapter_android_.CancelComposition();
 }
 
+void RenderWidgetHostViewAndroid::ImeCompositionRangeChanged(
+    const gfx::Range& range,
+    const std::vector<gfx::Rect>& character_bounds) {
+  // TODO(yukawa): Implement this.

[Mike West, 2014/10/25 05:59:53]

It doesn't look like the existing implementation is doing any sanity checking
for the size of the passed vector. It would be worth adding some reasonable
upper bound, but that certainly doesn't have to happen in this CL.

[sky, 2014/10/27 15:28:32]

NOTIMPLEMENTED?

[yukawa, 2014/10/27 16:10:29]

Acknowledged.

[yukawa, 2014/10/27 16:10:29]

Thanks but let me keep this as a comment. I'd like to not introduce a possible
log spam here because this callback actually starts being called in Android 5.0
with this CL.  Hopefully this method will be implemented shortly with subsequent
CLs.

+}
+
 void RenderWidgetHostViewAndroid::FocusedNodeChanged(bool is_editable_node) {
   ime_adapter_android_.FocusedNodeChanged(is_editable_node);
   if (selection_controller_)
     selection_controller_->OnSelectionEditable(is_editable_node);
 }
 
 void RenderWidgetHostViewAndroid::RenderProcessGone(
     base::TerminationStatus status, int error_code) {
   Destroy();
 }
@@ skipping 1020 matching lines @@
   results->orientationAngle = display.RotationAsDegree();
   results->orientationType =
       RenderWidgetHostViewBase::GetOrientationTypeForMobile(display);
   gfx::DeviceDisplayInfo info;
   results->depth = info.GetBitsPerPixel();
   results->depthPerComponent = info.GetBitsPerComponent();
   results->isMonochrome = (results->depthPerComponent == 0);
 }
 
 } // namespace content